Skip to content

Commit

Permalink
Fix Reverb model (FREEVERB) for old songs (#3070)
Browse files Browse the repository at this point in the history
* Fix Reverb model (FREEVERB) for old songs

* Remove setting reverb model before file load
  • Loading branch information
stellar-aria committed Dec 15, 2024
1 parent 487c41d commit 10485d2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/deluge/model/song/song.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1328,7 +1328,7 @@ Error Song::readFromFile(Deserializer& reader) {

// reverb mode is freeverb for songs that predate having multiple options. New songs will set it to mutable anyway
// so this is only used as a fallback
AudioEngine::reverb.setModel(deluge::dsp::Reverb::Model::FREEVERB);
model = deluge::dsp::Reverb::Model::FREEVERB;

while (*(tagName = reader.readNextTagOrAttributeName())) {
// D_PRINTLN(tagName); delayMS(30);
Expand Down
4 changes: 1 addition & 3 deletions src/deluge/processing/engines/audio_engine.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1344,9 +1344,7 @@ void stopAnyPreviewing() {
}

void getReverbParamsFromSong(Song* song) {

reverb.setModel(static_cast<dsp::Reverb::Model>(song->model));

reverb.setModel(song->model);
reverb.setRoomSize(song->reverbRoomSize);
reverb.setDamping(song->reverbDamp);
reverb.setWidth(song->reverbWidth);
Expand Down

0 comments on commit 10485d2

Please sign in to comment.