v2.1.6 (#19)

* Updated Makefile to add versions to the asset imports in the header * Update hooks.php Fixed up the missing " that causes all public facing pages to break. * Update synergywholesaledomains.php Co-authored-by: Brad Baker <[email protected]>
SynergyWholesale · May 14, 2020 · a310002 · a310002
1 parent ed4dc0b
commit a310002
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -15,6 +15,11 @@ Synergy Wholesale WHMCS Domains Module
 ### Removed
 -
 
+## 2.1.6 [Updated 14/05/2020]
+
+### Fixed
+- Fixed an unclosed quote in the header when importing a JS asset. Fixes [#16](https://github.com/SynergyWholesale/WHMCS-Domains-Module/issues/16)
+
 ## 2.1.5 [Updated 13/05/2020]
 
 ### Fixed

diff --git a/Makefile b/Makefile
@@ -33,16 +33,18 @@ replace:
 revert:
 	sed -i${SED_PARAM} "s/${VERSION}/{{VERSION}}/g" "README.txt"
 	sed -i${SED_PARAM} "s/${RELEASE_DATE}/{{RELEASE_DATE}}/g" "README.txt"
-	sed -i${SED_PARAM} "s/{{VERSION}}/${VERSION:v%=%}/g" "modules/registrars/synergywholesaledomains/hooks.php"
+	sed -i${SED_PARAM} "s/${VERSION:v%=%}/{{VERSION}}/g" "modules/registrars/synergywholesaledomains/hooks.php"
 	sed -i${SED_PARAM} "s/${VERSION:v%=%}/{{VERSION}}/g" "modules/registrars/synergywholesaledomains/synergywholesaledomains.php"
 	sed -i${SED_PARAM} "s/${SW_API_HOSTNAME}/{{API}}/g" "modules/registrars/synergywholesaledomains/synergywholesaledomains.php"
 	sed -i${SED_PARAM} "s/${SW_FRONTEND_HOSTNAME}/{{FRONTEND}}/g" "modules/registrars/synergywholesaledomains/synergywholesaledomains.php"
 
 package:
+	make replace
 	zip -r "synergy-wholesale-domains-$(VERSION).zip" . -x  \
 	'.DS_Store' '**/.DS_Store' '*.cache' '.git*' '*.md' 'Makefile' 'package.json' 'package-lock.json' \
 	'composer.json' 'composer.lock' '*.xml'  '**/synergywholesaledomains.css' '**/functions.js' \
 	'vendor/*' 'node_modules/*' '.git/*' 'tests/*'
+	make revert
 
 build:
 	make test

diff --git a/modules/registrars/synergywholesaledomains/hooks.php b/modules/registrars/synergywholesaledomains/hooks.php
@@ -84,7 +84,7 @@
     return str_replace('{WEB_ROOT}', $vars['WEB_ROOT'], '
         <script data-cfasync="false" src="//cdnjs.cloudflare.com/ajax/libs/toastr.js/latest/js/toastr.min.js"></script>
         <link href="//cdnjs.cloudflare.com/ajax/libs/toastr.js/latest/css/toastr.min.css" rel="stylesheet" />
-        <script data-cfasync="false" src="{WEB_ROOT}/modules/registrars/synergywholesaledomains/js/functions.min.js?v={{VERSION}}></script>
+        <script data-cfasync="false" src="{WEB_ROOT}/modules/registrars/synergywholesaledomains/js/functions.min.js?v={{VERSION}}"></script>
         <link rel="stylesheet" type="text/css" href="{WEB_ROOT}/modules/registrars/synergywholesaledomains/css/synergywholesaledomains.min.css?v={{VERSION}}" />
     ');
 });

diff --git a/modules/registrars/synergywholesaledomains/synergywholesaledomains.php b/modules/registrars/synergywholesaledomains/synergywholesaledomains.php
@@ -45,7 +45,7 @@ function synergywholesaledomains_helper_getDomain(array $params)
 
 function synergywholesaledomains_helper_getNameservers(array $params)
 {
-    $namesevers = [];
+    $nameservers = [];
     for ($i = 1; $i < 6; $i++) {
         if (empty($params["ns$i"])) {
             continue;