Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust QSplitter style #689

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Adjust QSplitter style #689

merged 1 commit into from
Sep 28, 2024

Conversation

luk1337
Copy link
Contributor

@luk1337 luk1337 commented Jul 15, 2024

This looks much better when using PySide6 6.7.2.

@luk1337
Copy link
Contributor Author

luk1337 commented Jul 15, 2024

Before:
Screenshot_20240715_180447

After:
Screenshot_20240715_180439

@luk1337
Copy link
Contributor Author

luk1337 commented Jul 15, 2024

I guess it'd be great if someone could test pyside2 and other platforms.

@Et0h
Copy link
Contributor

Et0h commented Jul 15, 2024

Tried on Windows 10 dark mode, and the difference is that the old version had a clear grab indicator for the horizontal splitter but the new version does not (both have a grab indicator for the vertical handle). I didn't see any difference for the light mode (where there are no vertical/horizontal grab bars in any case).
Old and new grab bar Syncplay

I wouldn't say having horizontal but not vertical grab bars on Windows 10 dark mode is an improvement, as it means the way it displays it is inconsistent between horizontal and vertical. I might not even notice if I wasn't paying attention, but making an explicit change which is a downgrade on Windows doesn't seem like an improvement. I don't know what OS and theme you are using where it works better for you, but it might also be the case that it looks worse in other circumstances as well.

@luk1337
Copy link
Contributor Author

luk1337 commented Jul 15, 2024

Tried on Windows 10 dark mode, and the difference is that the old version had a clear grab indicator for the horizontal splitter but the new version does not (both have a grab indicator for the vertical handle). I didn't see any difference for the light mode (where there are no vertical/horizontal grab bars in any case). Old and new grab bar Syncplay

I wouldn't say having horizontal but not vertical grab bars on Windows 10 dark mode is an improvement, as it means the way it displays it is inconsistent between horizontal and vertical. I might not even notice if I wasn't paying attention, but making an explicit change which is a downgrade on Windows doesn't seem like an improvement. I don't know what OS and theme you are using where it works better for you, but it might also be the case that it looks worse in other circumstances as well.

hmm, I tried Window 10 in light mode and there was no indicator, so I just killed it. But if dark mode somehow has it, I guess I'll maybe try to look into where it comes from.

This looks much better when using PySide6 6.7.2.
@luk1337
Copy link
Contributor Author

luk1337 commented Jul 15, 2024

What about current diff? It looks like this on my system:

image

@luk1337
Copy link
Contributor Author

luk1337 commented Jul 15, 2024

And looks like this without custom handle width:
image

@Et0h
Copy link
Contributor

Et0h commented Jul 15, 2024

The new version looks fine to me on Windows 10 Dark Mode now, and it now has the resize bars in Windows 10 Light Mode which I would consider an improvement.

@daniel-123
Copy link
Contributor

Over here with pySide2 it seems to look exactly the same as originally.

@daniel-123 daniel-123 merged commit 91b40db into Syncplay:master Sep 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants