Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to python 3.12 #636

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Update to python 3.12 #636

merged 2 commits into from
Oct 11, 2023

Conversation

kilmanio
Copy link
Contributor

SafeConfigParser was renamed to ConfigParser (docs)

.readfp() was renamed to .read_file() (docs)

Otherwise trying to run the client with python 3.12 gets you this nice error

> python syncplayClient.py
Traceback (most recent call last):
  File "[]/syncplay/syncplayClient.py", line 14, in <module>
    from syncplay import ep_client
  File "[]/syncplay/syncplay/ep_client.py", line 3, in <module>
    from syncplay.clientManager import SyncplayClientManager
  File "[]/syncplay/clientManager.py", line 4, in <module>
    from syncplay.ui.ConfigurationGetter import ConfigurationGetter
  File "/usr/lib/python3.12/site-packages/shiboken2/files.dir/shibokensupport/feature.py", line 139, in _import
    return original_import(name, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "[]/syncplay/syncplay/ui/ConfigurationGetter.py", line 8, in <module>
    from configparser import SafeConfigParser, DEFAULTSECT
ImportError: cannot import name 'SafeConfigParser' from 'configparser' (/usr/lib/python3.12/configparser.py). Did you mean: 'RawConfigParser'?

@Et0h
Copy link
Contributor

Et0h commented Oct 11, 2023

Thanks for this commit to improve Syncplay compatibility.

You didn't specify impact on earlier versions of Python, but I had a check and readfp being used instead of read_file seems to date back to Python 3.2. As the earliest supported version of Python that is still being supported is 3.8 this seems not to be an issue.

@Et0h Et0h merged commit 7456a94 into Syncplay:master Oct 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants