Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sbol3update #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sbol3update #41

wants to merge 2 commits into from

Conversation

goksel
Copy link
Contributor

@goksel goksel commented Apr 28, 2023

Updated the SBOL3 examples based in validation rules.

@goksel goksel requested a review from tcmitchell April 28, 2023 12:34
@tcmitchell
Copy link
Contributor

@goksel can you explain what validation rules were being violated and how these changes fix things? Many of the changes I see, like simple value changes, do not seem like they would be invalid based on the SBOL3 validation rules. I need more information in order to give this a review. Thanks!

@goksel
Copy link
Contributor Author

goksel commented Apr 28, 2023

Thanks Tom, you are correct most of them are value changes. However, as far as I remember, there were some cases where I had to add roles and update DBTL-related entities with sbol-specific terms (e.g. sbol:design). This means some of the previous files are not valid. You can look at the ttl files only perhaps to make the review easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants