-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test rdf file #39
base: master
Are you sure you want to change the base?
Test rdf file #39
Conversation
@ahmedtarek26 thanks for the proposed update. Can you please add a description to this pull request so that we can understand what this change is and why it is being done? I have no context for this change or these files. |
@tcmitchell I added rdf file to the rdf directory and gb file to the gb files directory then I run the test_roundtrip.py from 'src/test/python'. |
What is the purpose for the test suite? While it may be valuable for you to experiment with this information to learn about it, we don't typically add code to a community project unless it improves the project for the community. |
I was trying to follow the steps written in the readme at the SBOLTestSuite repo and I found that I can make a pull request if the test is done. |
@ahmedtarek26 thanks for taking the time to test things out.
We're happy to merge in the test files if they add additional test cases. So far, I cannot tell if they do add additional test cases, or if they were only to allow you to experiment with the unit testing. |
SBOL3 file should be in a subdirectory under SBOL3, not RDF which is for SBOL2 RDF files. |
@tcmitchell yeah I ran the unit test for SBOLTestSuite in my local environment. the test files you added to the directory to test it but there's a problem with the unit test I'm trying to understand it. |
@cjmyers Ahaa , Thanks I'll change the file path. |
You should be able to run the round trip testing without the additional "in /path/to/small-molecule-etc.rdf". Try just "python -m unittest /path/to/test_round_trip.py" for example. Please excuse typos, I am on the go. |
No description provided.