Update ResetPasswordRequestTrait.php #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution for [ISSUES 289] (SymfonyCasts#287)
jrushlow
requested changes
Apr 24, 2024
There was a problem hiding this comment.
Thank you @featuriz for the PR. Unfortunately, we can't merge this in v1 because it is a breaking change. But we have removed the annotations for v2 #303
The root of this problem stems from an upstream change in either doctrine/annotations or doctrine/doctrineBundle - although I'm still trying to narrow it down to see what exactly the problem is. But, as I work out the problem and solution for v1 users - I'll keep everyone updated in #287
Thanks again!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution for [ISSUES 289]
(#287)