Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated poll cog to new extension format #245

Merged
merged 23 commits into from
Nov 2, 2023
Merged

Migrated poll cog to new extension format #245

merged 23 commits into from
Nov 2, 2023

Conversation

FirePlank
Copy link
Contributor

Migrated poll cog to new extension format and also fixed a slight alignment issue with the rank card. This PR fixes the issue addressed at #223.

Copy link
Collaborator

@HETHAT HETHAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the ugly excepts in show command, it seems fine

bot/extensions/polls/events.py Outdated Show resolved Hide resolved
bot/extensions/polls/commands.py Outdated Show resolved Hide resolved
bot/extensions/polls/commands.py Outdated Show resolved Hide resolved
bot/extensions/polls/commands.py Outdated Show resolved Hide resolved
@FirePlank FirePlank requested a review from SylteA October 27, 2023 08:57
bot/extensions/polls/views.py Outdated Show resolved Hide resolved
bot/extensions/polls/views.py Outdated Show resolved Hide resolved
bot/extensions/polls/views.py Outdated Show resolved Hide resolved
bot/extensions/polls/views.py Outdated Show resolved Hide resolved
bot/extensions/polls/views.py Outdated Show resolved Hide resolved
bot/extensions/polls/events.py Outdated Show resolved Hide resolved
bot/extensions/polls/commands.py Outdated Show resolved Hide resolved
bot/core.py Show resolved Hide resolved
@FirePlank FirePlank requested a review from SylteA October 30, 2023 18:01
Copy link
Owner

@SylteA SylteA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, remove the chatgpt comments

bot/extensions/polls/events.py Outdated Show resolved Hide resolved
bot/extensions/polls/commands.py Outdated Show resolved Hide resolved
bot/extensions/polls/commands.py Outdated Show resolved Hide resolved
bot/extensions/polls/views.py Outdated Show resolved Hide resolved
@FirePlank FirePlank requested a review from SylteA October 30, 2023 20:23
bot/extensions/polls/commands.py Outdated Show resolved Hide resolved
@FirePlank FirePlank requested a review from SylteA November 1, 2023 14:57
@SylteA SylteA merged commit 23dcfc1 into SylteA:dev Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants