bug fixes

SylteA · Nov 21, 2023 · 4835bb9 · 4835bb9
1 parent 5c13693
commit 4835bb9
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/bot/extensions/selectable_roles/commands.py b/bot/extensions/selectable_roles/commands.py
@@ -57,12 +57,13 @@ async def get(
     ):
         """Get the selected role"""
 
-        if not self.roles.get(interaction.guild.id):
-            return await interaction.response.send_message("There are no selectable roles!", ephemeral=True)
+        if not self.roles.get(interaction.guild.id) or not role.isdigit():
+            return await interaction.response.send_message("That role isn't selectable!", ephemeral=True)
 
         role = interaction.guild.get_role(int(role))
-        if role is None:
-            return await interaction.response.send_message("That role doesn't exist!", ephemeral=True)
+        if role is None or not any(role.id == role_.id for role_ in self.roles[interaction.guild.id]):
+            return await interaction.response.send_message("That role isn't selectable!", ephemeral=True)
+
         await interaction.user.add_roles(role, reason="Selectable role")
 
         to_remove = []