Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name of file inside the comments for BookFactory #747

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix name of file inside the comments for BookFactory #747

merged 1 commit into from
Oct 16, 2023

Conversation

harikt
Copy link
Contributor

@harikt harikt commented Oct 14, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes parts of documentation.
License MIT

@harikt harikt requested a review from a team as a code owner October 14, 2023 12:00
oallain
oallain approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM 👍

@lchrusciel lchrusciel merged commit 3449806 into Sylius:1.11 Oct 16, 2023
60 checks passed
@lchrusciel
Copy link
Member

Thank you, @harikt!

@harikt harikt deleted the patch-1 branch October 16, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafikooo Rafikooo Rafikooo approved these changes

@loic425 loic425 loic425 approved these changes

@oallain oallain oallain approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

@diimpp diimpp diimpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@harikt @lchrusciel @diimpp @oallain @loic425 @Rafikooo