Upgrade to 2.0 #323
Merged
Upgrade to 2.0 #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheMilek
commented
Oct 11, 2024
•
TheMilek
commented
TheMilek
force-pushed
the
SYL-3915
branch
3 times, most recently
from
9dd3574
to
69f045a
Compare
TheMilek
force-pushed
the
SYL-3915
branch
12 times, most recently
from
10c56e7
to
571ff5a
Compare
Wojdylak
reviewed
Oct 14, 2024
| run: vendor/bin/behat --colors --strict -vvv --no-interaction -f progress || vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --rerun | ||
| run: | | ||
| if [ "${{ matrix.wkhtmltopdf }}" != "false" ]; then | ||
| vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --tags="~@pdf_disabled" || vendor/bin/behat --colors --strict -vvv --no-interaction -f progress --rerun; |
There was a problem hiding this comment.
dont really know, but seems like the extension friends-of-behat/exclude-specifications-extension was doing the trick before
src/templates/admin/invoice/show/content/page_body/buyer.html.twig
Outdated
Show resolved
Hide resolved
src/templates/admin/invoice/show/content/page_body/buyer/company.html.twig
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Oct 15, 2024
src/templates/admin/invoice/show/content/page_body/seller.html.twig
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3915
branch
2 times, most recently
from
dc74d02
to
3869edd
Compare
Wojdylak
approved these changes
Oct 16, 2024
src/templates/admin/invoice/show/content/header/title_block/actions/back_to_index.html.twig
Outdated
Show resolved
Hide resolved
src/templates/admin/invoice/show/content/sections/card/footer.html.twig
Outdated
Show resolved
Hide resolved
TheMilek
force-pushed
the
SYL-3915
branch
5 times, most recently
from
33ce137
to
a33aa2c
Compare
GSadee
approved these changes
Oct 18, 2024
| @@ -1,3 +1,10 @@ | |||
| ### UPGRADE FROM 0.24.X TO 1.0.0 | |||
There was a problem hiding this comment.
We will probably release support for Sylius 2.0 in version 2.0 of this plugin, and release earlier 1.0, but we could adjust it later 🖖🏻
|
|
||
| 1. Support for Sylius 2.0 has been added, it is now the recommended Sylius version to use with InvoicingPlugin. | ||
| 2. Support for Sylius 1.13 and 1.12 has been dropped, upgrade your application to [Sylius 2.0](https://github.com/Sylius/Sylius/blob/2.0/UPGRADE-2.0.md). | ||
| 3. Support for PHP has been increased to 8.2 |
There was a problem hiding this comment.
Suggested change
| 3. Support for PHP has been increased to 8.2 | |
| 3. The minimum supported PHP version has been changed to 8.2 |
🤔
Comment on lines
+2
to
+3
| - { resource: "@SyliusInvoicingPlugin/Resources/config/app/winzou_state_machine.php" } | ||
| - { resource: 'app/twig_hooks/**/*.yaml' } |
There was a problem hiding this comment.
Make these imports consistent with each other
Comment on lines
+15
to
+16
| id="sylius_invoicing.twig.component.invoice.list" | ||
| class="Sylius\InvoicingPlugin\Twig\Component\Invoice\ListComponent" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.