Check if transition can be applied before apply it during order creation #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximehuran
force-pushed
the
feature/correct-virtual-order-creation
branch
from
b2c23d2 to
caf95fb
Compare
lchrusciel
approved these changes
Jul 18, 2019
Zales0123
reviewed
Jul 22, 2019
| $stateMachine->can(OrderCheckoutTransitions::TRANSITION_ADDRESS)->shouldBeCalled(); | ||
| $stateMachine->can(OrderCheckoutTransitions::TRANSITION_SELECT_SHIPPING)->shouldBeCalled(); | ||
| $stateMachine->can(OrderCheckoutTransitions::TRANSITION_SELECT_PAYMENT)->shouldBeCalled(); | ||
| $stateMachine->can(OrderCheckoutTransitions::TRANSITION_COMPLETE)->shouldBeCalled(); |
There was a problem hiding this comment.
I believe apply(...)->shouldBeCalled() should still be there. More, all of these should be $stateMachine->can(...)->willReturn(true); We should also create at least one spec when some of the transition cannot be called (and check that apply(...)->shouldNotBeCalled()
|
@maximehuran can you also take a look at the failing build? And I agree with @lchrusciel, but it can be done as an improvement, let's focus on fixing a bug 🚀 |
|
Hi, I don't get how to avoid having this error. Is is still a bug or what should I do? |
GSadee
added a commit
that referenced
this pull request
Feb 25, 2022
…i, GSadee) This PR was merged into the 1.1-dev branch. Discussion ---------- This is similar to already existing PR, but i think original poster stopped responding so I can try to get that working. Issue: #134 However, the issue also appears when product is not virtual, but skipping_shipping_step_allowed in channel PR: #132 Commits ------- c1f47db Fix state machine exception on order creation bc25387 added phpspec tests 10bf4b5 Remove PHPUnit cache file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #132
Apply transition only if we can apply it.
During virtual order creation, this avoid the exception :
Transition "select_shipping" cannot be applied on state "shipping_skipped" of object "App\Entity\Order\Order" with graph "sylius_order_checkout"