Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow session TTL values to be set #3826

Merged
merged 7 commits into from
Oct 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions helm-chart/renku/templates/gateway/configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ data:
{{- toYaml . | nindent 8 }}
{{- end }}
sessions:
{{- if .Values.gateway.idleSessionTTLSeconds }}
idleSessionTTLSeconds: {{ .Values.gateway.idleSessionTTLSeconds }}
{{- end }}
{{- if .Values.gateway.maxSessionTTLSeconds }}
maxSessionTTLSeconds: {{ .Values.gateway.maxSessionTTLSeconds }}
{{- end }}
authorizationVerifiers:
- issuer: {{ printf "%s/realms/%s" (include "renku.keycloakUrl" . | trimSuffix "/") (include "renku.keycloak.realm" .) }}
audience: renku
Expand Down
9 changes: 9 additions & 0 deletions helm-chart/renku/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1266,6 +1266,15 @@ gateway:
## average rate units are requests per second
average: 20
burst: 100
## How long a session will be kept alive if it is idle.
## If set to 0 then there is no TTL.
## If not set, defaults to 14400 (4 hours).
idleSessionTTLSeconds:
## The maximum duration a session can be kept alive.
## If set to 0 then there is no TTL.
## If this value is set to a value other than 0 then it must be greater than idleSessionTTLSeconds.
## If not set, defaults to 86400 (24 hours).
maxSessionTTLSeconds:
## For production deployment, you will need to define the secret key.
## This is a random string, used for cryptographic operations on cookies and sensitive information.
## Use `openssl rand -hex 32`.
Expand Down
5 changes: 5 additions & 0 deletions helm-chart/values.yaml.changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ For changes that require manual steps other than changing values, please check o
Please follow this convention when adding a new row
* `<type: NEW|EDIT|DELETE> - *<resource name>*: <details>`

## Upgrading to Renku 0.60.0

* NEW ``gateway.idleSessionTTLSeconds`` to set the session idle TTL in seconds.
* NEW ``gateway.maxSessionTTLSeconds`` to set the session max TTL in seconds.

## Upgrading to Renku 0.59.1

* NEW ``notebooks.bypassCacheOnFailure`` has been added. Setting this to false prevents renku-notebooks to call
Expand Down
Loading