Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update from auto-update/renku-core-2.9.1 #3433

Merged
merged 9 commits into from
Jan 22, 2024
Merged

Update from auto-update/renku-core-2.9.1 #3433

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
567b268
chore: updating renku-core version to 2.9.1
RenkuBot Jan 19, 2024
21a2fdd
Update CHANGELOG.rst
Panaetius Jan 19, 2024
9b30973
test(cypress): disable test to update an old project
lorenzo-cavazzi Jan 19, 2024
c32a562
Merge branch 'master' into auto-update/renku-core-2.9.1
lorenzo-cavazzi Jan 22, 2024
b30796c
chore: bump UI version to 3.17.3
lorenzo-cavazzi Jan 22, 2024
418a33c
chore: use the skip function on the disabled test
lorenzo-cavazzi Jan 22, 2024
764bf93
chore: selenium updated
jachro Jan 22, 2024
26f8676
update changelog
Panaetius Jan 22, 2024
e766bee
update changelog
Panaetius Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
.. _changelog:

0.46.1
Panaetius marked this conversation as resolved.
Show resolved Hide resolved
------

Renku ``0.46.1`` contains a bugfix for issues some users are facing when migrating projects to the newest metadata version.

User-Facing Changes
~~~~~~~~~~~~~~~~~~~

**🐞 Bug Fixes**

- **Core Service**: Fix migrations not working when the Dockerfile needs to be migrated as well
(`#3687 <https://github.com/SwissDataScienceCenter/renku-python/pull/3687>`_).

Individual Components
~~~~~~~~~~~~~~~~~~~~~
- `renku-python 2.9.1 <https://github.com/SwissDataScienceCenter/renku-python/releases/tag/v2.9.1>`_


0.46.0
------

Expand Down
143 changes: 72 additions & 71 deletions cypress-tests/cypress/e2e/updateProjects.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,77 +41,78 @@ describe("Fork and update old projects", () => {
);
});

it("Update a very old project - version and template", () => {
// fork the project
const tempName = generatorProjectName("projectUpdateV8");
if (projects.shouldFork) {
const forkedProject = {
namespace: projects.namespace,
name: projects.v8,
};
cy.visitAndLoadProject(forkedProject, true);
cy.getDataCy("header-project")
.contains("Error obtaining datasets")
.should("be.visible");
cy.forkProject(forkedProject, tempName);
}

// get to the status page
const targetProject = projects.shouldFork
? { namespace: username, name: tempName }
: { namespace: projects.namespace, name: projects.v8 };
if (!projects.shouldFork) cy.visitAndLoadProject(targetProject, true);
// eslint-disable-next-line cypress/no-unnecessary-waiting
cy.wait(2_000);
cy.getProjectSection("Settings").click();

// verify project requires update
cy.getDataCy("project-status-icon-element").should("be.visible");
cy.getDataCy("project-settings-migration-status")
.contains("Project update required")
.should("be.visible");
cy.getDataCy("project-version-section-open").should("be.visible").click();
cy.getDataCy("project-settings-migration-status")
.contains("still on version 8 while the latest version is")
.should("be.visible");
cy.getDataCy("project-settings-migration-status")
.get("#button-update-projectMigrationStatus")
.as("button-trigger-migration")
.should("be.visible");
cy.get("@button-trigger-migration").should("be.visible").click();
cy.getDataCy("project-settings-migration-status")
.contains("button", "Updating")
.should("be.visible");
cy.getDataCy("project-settings-migration-status")
.contains("Refreshing project data")
.should("be.visible");
cy.getDataCy("project-settings-migration-status")
.contains("This project uses the latest")
.should("be.visible");
cy.getDataCy("project-status-icon-element").should("not.exist");

// update template
cy.getDataCy("project-settings-migration-status")
.contains("There is a new version of the template")
.should("be.visible");
cy.getDataCy("project-settings-migration-status")
.get("#button-update-projectMigrationStatus")
.as("button-update-template")
.should("be.visible");
cy.get("@button-update-template").should("be.visible").click();
cy.getDataCy("project-settings-migration-status")
.contains("button", "Updating")
.should("be.visible");
cy.getDataCy("project-settings-migration-status")
.contains("Refreshing project data")
.should("be.visible");
cy.getDataCy("project-settings-migration-status")
.contains("Project up to date")
.should("be.visible");

// delete the project
if (projects.shouldFork) cy.deleteProjectFromAPI(targetProject);
});
// ? This is disabled cause updating older projects now sometimes requires double migrations
// it("Update a very old project - version and template", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use .skip here

// // fork the project
// const tempName = generatorProjectName("projectUpdateV8");
// if (projects.shouldFork) {
// const forkedProject = {
// namespace: projects.namespace,
// name: projects.v8,
// };
// cy.visitAndLoadProject(forkedProject, true);
// cy.getDataCy("header-project")
// .contains("Error obtaining datasets")
// .should("be.visible");
// cy.forkProject(forkedProject, tempName);
// }

// // get to the status page
// const targetProject = projects.shouldFork
// ? { namespace: username, name: tempName }
// : { namespace: projects.namespace, name: projects.v8 };
// if (!projects.shouldFork) cy.visitAndLoadProject(targetProject, true);
// // eslint-disable-next-line cypress/no-unnecessary-waiting
// cy.wait(2_000);
// cy.getProjectSection("Settings").click();

// // verify project requires update
// cy.getDataCy("project-status-icon-element").should("be.visible");
// cy.getDataCy("project-settings-migration-status")
// .contains("Project update required")
// .should("be.visible");
// cy.getDataCy("project-version-section-open").should("be.visible").click();
// cy.getDataCy("project-settings-migration-status")
// .contains("still on version 8 while the latest version is")
// .should("be.visible");
// cy.getDataCy("project-settings-migration-status")
// .get("#button-update-projectMigrationStatus")
// .as("button-trigger-migration")
// .should("be.visible");
// cy.get("@button-trigger-migration").should("be.visible").click();
// cy.getDataCy("project-settings-migration-status")
// .contains("button", "Updating")
// .should("be.visible");
// cy.getDataCy("project-settings-migration-status")
// .contains("Refreshing project data")
// .should("be.visible");
// cy.getDataCy("project-settings-migration-status")
// .contains("This project uses the latest")
// .should("be.visible");
// cy.getDataCy("project-status-icon-element").should("not.exist");

// // update template
// cy.getDataCy("project-settings-migration-status")
// .contains("There is a new version of the template")
// .should("be.visible");
// cy.getDataCy("project-settings-migration-status")
// .get("#button-update-projectMigrationStatus")
// .as("button-update-template")
// .should("be.visible");
// cy.get("@button-update-template").should("be.visible").click();
// cy.getDataCy("project-settings-migration-status")
// .contains("button", "Updating")
// .should("be.visible");
// cy.getDataCy("project-settings-migration-status")
// .contains("Refreshing project data")
// .should("be.visible");
// cy.getDataCy("project-settings-migration-status")
// .contains("Project up to date")
// .should("be.visible");

// // delete the project
// if (projects.shouldFork) cy.deleteProjectFromAPI(targetProject);
// });

it("Update an outdated project - verify commits have been added", () => {
// fork the project
Expand Down
6 changes: 6 additions & 0 deletions event.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"action":"workflow_dispatch",
"inputs":{
"version":"9.99.9"
}
}
7 changes: 3 additions & 4 deletions helm-chart/renku/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ global:
fullnameOverride: ""
image:
repository: renku/renku-core
tag: "v2.8.2"
tag: "v2.9.1"
pullPolicy: IfNotPresent
uiserver:
## The client secret for the renku-ui client application registered in keycloak.
Expand Down Expand Up @@ -1273,8 +1273,7 @@ jena:
compacting:
- name: ADMIN_USER
value: admin
- ## The 'Mon *-*-* 00:00:00' expression means the process will be run every Monday at 00:00:00. More details at https://github.com/eikek/calev
name: COMPACTING_SCHEDULE
- name: COMPACTING_SCHEDULE ## The 'Mon *-*-* 00:00:00' expression means the process will be run every Monday at 00:00:00. More details at https://github.com/eikek/calev
value: "Mon *-*-* 00:00:00"
resources:
requests:
Expand Down Expand Up @@ -1509,4 +1508,4 @@ affinity: {}
versions:
latest:
image:
tag: v2.8.2
tag: v2.9.1
Loading