refactor: use cy.session for anonymous user checks (#3802)

Remove the `logout()` command and use `cy.session()` instead. This makes the tests less flaky.

cypress-tests/cypress/e2e/privateProject.cy.ts

@@ -38,7 +38,11 @@ describe("Basic public project functionality", () => {
       },
       validateLogin
     );
-    cy.createProjectIfMissing({templateName: "Python", ...projectIdentifier, visibility: "private"});
+    cy.createProjectIfMissing({
+      templateName: "Python",
+      ...projectIdentifier,
+      visibility: "private",
+    });
     cy.visitAndLoadProject(projectIdentifier);
   });
 
@@ -50,11 +54,11 @@ describe("Basic public project functionality", () => {
       .should("be.checked");
     cy.searchForProject(projectIdentifier, true);
 
-    // logout and search for the project and log back in
-    cy.logout();
+    // Check as an anonymous user
+    cy.session(["anonymous", getRandomString()], () => {});
+    cy.visit("/");
     cy.get("#nav-hamburger").should("be.visible").click();
     cy.searchForProject(projectIdentifier, false);
-    cy.robustLogin();
   });
 
   it("Can always search for project after changing the visibility", () => {
@@ -86,10 +90,11 @@ describe("Basic public project functionality", () => {
 
     // Search the project as both logged in and logged out.
     cy.searchForProject(projectIdentifier, true);
-    cy.logout();
+    // Check as an anonymous user
+    cy.session(["anonymous", getRandomString()], () => {});
+    cy.visit("/");
     cy.get("#nav-hamburger").should("be.visible").click();
     cy.searchForProject(projectIdentifier, false);
-    cy.robustLogin();
   });
 
   it("Deleting the project removes it from the search page", () => {

cypress-tests/cypress/e2e/publicProject.cy.ts

@@ -48,11 +48,11 @@ describe("Basic public project functionality", () => {
     cy.waitMetadataIndexing();
     cy.searchForProject(projectIdentifier);
 
-    // logout and search for the project and log back in
-    cy.logout();
+    // Check as an anonymous user
+    cy.session(["anonymous", getRandomString()], () => {});
+    cy.visit("/");
     cy.get("#nav-hamburger").should("be.visible").click();
     cy.searchForProject(projectIdentifier);
-    cy.robustLogin();
   });
 
   it("Can see overview content and check the clone URLs", () => {

cypress-tests/cypress/e2e/useSession.cy.ts

@@ -167,7 +167,7 @@ describe("Basic public project functionality", () => {
 
   it("Start a new session as anonymous user.", () => {
     // Do not re-use the logged-in session
-    cy.session("anonymous", () => {});
+    cy.session(["anonymous", getRandomString()], () => {});
 
     // Log out and go to the project again
     cy.visit("/");

cypress-tests/cypress/support/commands/login.ts

@@ -1,9 +1,11 @@
 const renkuLogin = (credentials: { username: string; password: string }[]) => {
-  cy.wrap(credentials, { log: false }).each((credential: {password: string, username: string}) => {
-    cy.get("#username").type(credential.username);
-    cy.get("#password").type(credential.password, { log: false });
-    cy.get("#kc-login").click()
-  })
+  cy.wrap(credentials, { log: false }).each(
+    (credential: { password: string; username: string }) => {
+      cy.get("#username").type(credential.username);
+      cy.get("#password").type(credential.password, { log: false });
+      cy.get("#kc-login").click();
+    }
+  );
   cy.url().then((url) => {
     const parsedUrl = new URL(url);
     if (
@@ -93,7 +95,7 @@ function registerAndVerify(props: RegisterAndVerifyProps) {
     expect(["/", ""]).to.include(loc.pathname);
     expect(loc.search).to.eq("");
     expect(loc.hostname).to.eq(baseURL.hostname);
-  })
+  });
   cy.get("header").should("be.visible");
   cy.get("footer").should("be.visible");
   // If we send a request to the user endpoint on Gitlab too quickly after we log in then
@@ -137,15 +139,7 @@ function robustLogin(props?: RobustLoginProps) {
   );
 }
 
-function logout() {
-  cy.get("#profile-dropdown").should("be.visible").click();
-  cy.get("#logout-link").should("be.visible").click();
-  // Make sure we fully log out
-  cy.wait(15_000);
-}
-
 export default function registerLoginCommands() {
-  Cypress.Commands.add("logout", logout);
   Cypress.Commands.add("renkuLogin", renkuLogin);
   Cypress.Commands.add("register", register);
   Cypress.Commands.add("registerAndVerify", registerAndVerify);
@@ -156,7 +150,6 @@ declare global {
   // eslint-disable-next-line @typescript-eslint/no-namespace
   namespace Cypress {
     interface Chainable {
-      logout();
       renkuLogin(credentials: { username: string; password: string }[]);
       register(
         email: string,