feat: known_hosts support for initial cloning #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to clone a git repository using the ssh protocol, one must accept to connect to the remote service as must be done when using ssh alone. Since it's an interactive operation that is not possible when in an init container, one solution is to provide the known_hosts files through a ConfigMap containing a list of validated hosts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR implements ssh's known_hosts handling to allow cloning git repositories using the ssh protocol.
In this initial implementation, the admin can create a ConfigMap object named
ssh-known-hostscontaining a key namedknown_hostswhich content should be the same as a standard known_hosts file.The content can be generate using
ssh-keyscanfollowed by the name of the git service of interest (for example GitHub, GitLab, Bitbucket, etc.).This method allows for both public and private git services to be used.
Issue ticket number and link
Fixes: #700
Part of SwissDataScienceCenter/renku#3679