Updated LoadingControllerView #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfoughty7
commented
Oct 4, 2024
There was a problem hiding this comment.
Given that each project uses different loading, error, empty views, I thought it made sense to move these out of the package.
There was a problem hiding this comment.
Hmm. I'd like to have simple defaults here. What was the primary motivation to remove the default views?
cfoughty7
commented
Oct 4, 2024
There was a problem hiding this comment.
Brought in some updates that were used for other projects.
There was a problem hiding this comment.
Is hard to see what all the changes are here. Is this just replacing the previous implementation with a version from some project? If so, which project?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.