-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signal Rohde&Schwarz SMB100A #115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franz-sweepMe
force-pushed
the
Signal-Rohde&Schwarz_SMB
branch
from
December 19, 2024 13:26
0992ada
to
6f26bbd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is a good example how to handle amplitude, high level, offset, low level, frequency, period, delay and phase:
https://github.com/SweepMe/instrument-drivers/blob/main/src/Signal-Siglent_SDG2000X/main.py
Is it possible to design the driver in a similar way?
franz-sweepMe
force-pushed
the
Signal-Rohde&Schwarz_SMB
branch
from
December 20, 2024 14:04
6f26bbd
to
63bb692
Compare
afischer-sweepme
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a signal generator driver for Rohde&Schwarz SMB100A
The driver has been tested with the device.
Before merging, the driver will be tested on SMC100A to see if the driver can be generalized.