Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal Rohde&Schwarz SMB100A #115

Merged
merged 9 commits into from
Dec 20, 2024
Merged

Signal Rohde&Schwarz SMB100A #115

merged 9 commits into from
Dec 20, 2024

Conversation

franz-sweepMe
Copy link
Contributor

Add a signal generator driver for Rohde&Schwarz SMB100A
The driver has been tested with the device.

Before merging, the driver will be tested on SMC100A to see if the driver can be generalized.

@franz-sweepMe franz-sweepMe requested a review from a team as a code owner December 19, 2024 10:53
@franz-sweepMe franz-sweepMe force-pushed the Signal-Rohde&Schwarz_SMB branch from 0992ada to 6f26bbd Compare December 19, 2024 13:26
Copy link
Contributor

@afischer-sweepme afischer-sweepme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a good example how to handle amplitude, high level, offset, low level, frequency, period, delay and phase:
https://github.com/SweepMe/instrument-drivers/blob/main/src/Signal-Siglent_SDG2000X/main.py

Is it possible to design the driver in a similar way?

src/Signal-Rohde&Schwarz_SMB100A/main.py Show resolved Hide resolved
src/Signal-Rohde&Schwarz_SMB100A/main.py Show resolved Hide resolved
src/Signal-Rohde&Schwarz_SMB100A/main.py Outdated Show resolved Hide resolved
@franz-sweepMe franz-sweepMe force-pushed the Signal-Rohde&Schwarz_SMB branch from 6f26bbd to 63bb692 Compare December 20, 2024 14:04
@franz-sweepMe franz-sweepMe merged commit 3c4f40b into main Dec 20, 2024
2 checks passed
@franz-sweepMe franz-sweepMe deleted the Signal-Rohde&Schwarz_SMB branch December 20, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants