update 90; few UI improvements in whatsnew dialog

Swati4star · Apr 15, 2019 · dada670 · dada670
1 parent 7c19b57
commit dada670
Show file tree

Hide file tree

Showing 6 changed files with 49 additions and 18 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -10,8 +10,8 @@ android {
         minSdkVersion 21
         multiDexEnabled true
         targetSdkVersion 28
-        versionCode 88
-        versionName "8.6.1"
+        versionCode 90
+        versionName "8.6.3"
     }
     buildTypes {
         release {

diff --git a/app/src/main/assets/whatsnew.json b/app/src/main/assets/whatsnew.json
@@ -2,21 +2,28 @@
   "data": [
 
     {
-      "title": "Invert PDF",
-      "content": "New feature to invert PDF colors",
-      "icon": "ic_invert_color_24dp"
+      "title": "Favourites Section",
+      "content": "You can now add your favourite features & get easy access to those.",
+      "icon": "ic_call_split_black_24dp"
     },
 
     {
-      "title": "Split PDF",
-      "content": "Added More ways to split PDF",
-      "icon": "ic_call_split_black_24dp"
+      "title": "View History",
+      "content": "Enhanced filters to view your history conversions",
+      "icon": "ic_history_black_24dp"
+    },
+
+
+    {
+      "title": "Excel to PDF",
+      "content": "You can now convert your excel files to PDF too!",
+      "icon": "ic_excel"
     },
 
     {
-      "title": "Fixed Crashes",
-      "content": "Fixed crashes & PDF conversion performance",
-      "icon": ""
+      "title": "Zip to PDF",
+      "content": "You can now convert your images zip files to PDF too!",
+      "icon": "ic_broken_image_black_24dp"
     }
 
   ],
@@ -25,6 +32,28 @@
     "version_code": [
     ],
 
+    "84": [
+
+      {
+        "title": "Invert PDF",
+        "content": "New feature to invert PDF colors",
+        "icon": "ic_invert_color_24dp"
+      },
+
+      {
+        "title": "Split PDF",
+        "content": "Added More ways to split PDF",
+        "icon": "ic_call_split_black_24dp"
+      },
+
+      {
+        "title": "Fixed Crashes",
+        "content": "Fixed crashes & PDF conversion performance",
+        "icon": ""
+      }
+
+    ],
+
     "83" : [
       {
         "title": "Remove duplicate pages",

diff --git a/app/src/main/java/swati4star/createpdf/activity/MainActivity.java b/app/src/main/java/swati4star/createpdf/activity/MainActivity.java
@@ -129,7 +129,7 @@ protected void onCreate(Bundle savedInstanceState) {
         }
 
         String versionName = mSharedPreferences.getString(VERSION_NAME, "");
-        if (!versionName.equals(BuildConfig.VERSION_NAME)) {
+        if (versionName != null && !versionName.equals(BuildConfig.VERSION_NAME)) {
             WhatsNewUtils.displayDialog(this);
             mSharedPreferences.edit().putString(VERSION_NAME, BuildConfig.VERSION_NAME).apply();
         }

diff --git a/app/src/main/java/swati4star/createpdf/adapter/ExtractImagesAdapter.java b/app/src/main/java/swati4star/createpdf/adapter/ExtractImagesAdapter.java
@@ -67,7 +67,8 @@ public class ViewMergeFilesHolder extends RecyclerView.ViewHolder implements Vie
 
         @Override
         public void onClick(View view) {
-            mOnClickListener.onFileItemClick(mFilePaths.get(getAdapterPosition()));
+            if (getAdapterPosition() < mFilePaths.size())
+                mOnClickListener.onFileItemClick(mFilePaths.get(getAdapterPosition()));
         }
     }
 

diff --git a/app/src/main/res/layout/fragment_whats_new.xml b/app/src/main/res/layout/fragment_whats_new.xml
@@ -15,6 +15,7 @@
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
+        android:padding="10dp"
         android:layout_marginBottom="50dp">
 
         <android.support.v7.widget.RecyclerView
@@ -24,7 +25,6 @@
 
     </LinearLayout>
 
-
     <Button
         android:id="@+id/continueButton"
         android:layout_width="match_parent"

diff --git a/app/src/main/res/layout/item_whats_new.xml b/app/src/main/res/layout/item_whats_new.xml
@@ -8,14 +8,14 @@
     <LinearLayout
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:layout_marginLeft="15dp"
+        android:layout_marginStart="8dp"
         android:layout_marginTop="10dp"
         android:orientation="horizontal">
 
         <ImageView
             android:id="@+id/icon"
-            android:layout_width="25dp"
-            android:layout_height="25dp"
+            android:layout_width="20dp"
+            android:layout_height="20dp"
             android:backgroundTint="@color/black" />
 
         <TextView
@@ -31,7 +31,8 @@
         android:id="@+id/description"
         android:layout_width="match_parent"
         android:layout_height="wrap_content"
-        android:layout_marginLeft="15dp"
+        android:layout_marginStart="15dp"
+        android:layout_marginEnd="15dp"
         android:layout_marginTop="5dp" />
 
 </LinearLayout>