Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
To ensure the generated string is a valid Python literal, this new code manually creates an instance of an AST constant node with the value parsed from the HAR and then uses
ast.unparse
.A few details worth reviewing:
The literal generation is implemented as an
entriesprocessor_with_args
defined in the main module, I don't think it fits as a plugin because it needs to be executed for the program to work properly.Since the output now includes the enclosing quotes, I removed them from the default template.
With the changes, the
apple-buy-a-mac
test started to fail. It seems the test was wrong: the expected output ignored backslashes that should be in the string, but got interpreted as part of a double quote escape sequence. It's now changed to reflect the correct expected output (and correct behaviour).