Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added global option with icon #744

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

OmChillure
Copy link

What does this PR do?

fixes #682

Where should the reviewer start?

Can start from constants/Superteam.ts.

How should this be manually tested?

By going to contstans/Superteam.ts.

Any background context you want to provide?

I added an object inside the array to render a option of Global, to navigate to home page with ease. I also added the icon.

What are the relevant issues?

Once user selects a region, the global option dissapears. this means user has to either remove the extra path on the address bar or reload the bounties/projects page to see the globally available bounties/projects again.

Screenshots (if appropriate)

Before
test

After
Screenshot 2024-09-15 122117

Copy link

vercel bot commented Sep 15, 2024

@OmChillure is attempting to deploy a commit to the Superteam Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@a20hek a20hek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we closing and opening prs over and over again for changes?
do them in the same PR unless absolutely necessary please
i want the stream of conversation and changes to be there

@OmChillure
Copy link
Author

OmChillure commented Sep 15, 2024

ohh sorry , I will keep this in mind! I will do changes in the same

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
earn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 0:00am

Copy link
Member

@a20hek a20hek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was away for a few weeks;
adding global as a superteam does this:
image

also, the global icon isn't an ios icon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants