How to query directories?

[webpro]

When trying out tinyglobby, I noticed it doesn't return directories the way I'd expect. So I wonder whether using the single star like this is invalid syntax and expected behavior. Is there a way with different syntax and/or options to make the tests pass already?

Or should we try and make this happen? :)

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/tinyglobby@80

commit: 882e3c7

[SuperchupuDev]

it's expected if it matches fast-glob. if it doesn't let me know and i'll fix it :)

[webpro]

I think the tests should pass when using onlyDirectories, fast-glob does this too:

• https://github.com/mrmlnc/fast-glob/blob/7f28b159a4e20b1da6e613beec363f8d5a52cb5a/__snapshots__/only-directories.e2e.js#L1-L5
• can't find a test/snapshot for '.' over there, but fast-glob returns the current dir '.' or absolute path thereof, depending on absolute option.

My observations only consider directories, but should align for onlyFiles:

• https://github.com/mrmlnc/fast-glob/blob/7f28b159a4e20b1da6e613beec363f8d5a52cb5a/__snapshots__/only-files.e2e.js#L1-L11

Also note that fast-glob does not suffix directories with /, whereas tinyglobby does. Personally I can appreciate tinyglobby's behavior, but it's good to know there's a diff.

[SuperchupuDev]

tested, it's a regression on main (works on 0.2.10). thanks for reporting! would have been chaotic if this bug made its way into a release

[SuperchupuDev]

looks like the bug isn't present in #76, so should be fixed once that gets merged

[webpro]

Splendid! Perhaps good to have tests to prevent regressions, the ones in this PR or others.

Let me know, I'd be happy to refactor or add more. Or close this PR.

[SuperchupuDev]

yep, will merge this once the bug is fixed :) can you refactor them so that they don't create a new fixture? should be possible to use the already created one

[webpro]

of course!