add support for leading ../
in patterns
#18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Status
unsure if it's needed, will only merge if i see actual usecases in the wild that break without this.
if you need this, please let me know!
kinda hacky, but i can't think of anything else. has a notable performance hit if patterns start with
../
unless ignore options are better configured by the userimagine you do the following:
where the projects directory contains
a/a.ts
andb/a.ts
, in addition to anode_modules
folder bigger than god knows what.in this case, tinyglobby infers a common root of
users/me/projects
, and it will start crawling every file under that root. this includes everything insidenode_modules
.as such, it does some extra crawling that can make the whole thing potentially very slow. one solution for this would be for the user to manually ignore everything they don't want:
this makes it fast again. thoughts?