-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Video Component #113
Draft
carlossantos74
wants to merge
5
commits into
lab
Choose a base branch
from
feat/video-meeting
base: lab
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New Video Component #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YJS - Run #174
🎉 All tests passed! |
Realtime - Run #174
🎉 All tests passed! |
SDK - Run #174
🎉 All tests passed! |
LCOV Report - SDK Web Components Test Coverage Report ✅All Files
Changed FilesN/A |
Realtime - Run #177
🎉 All tests passed! |
YJS - Run #177
🎉 All tests passed! |
SDK - Run #177
🎉 All tests passed! |
YJS - Run #178
🎉 All tests passed! |
Realtime - Run #178
🎉 All tests passed! |
SDK - Run #178
🎉 All tests passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!WIP
The goal is to develop a new video component specifically focused on video conferencing, while retaining all existing functionalities. This approach aims to enhance developer experience (DX) by providing a streamlined interface tailored to a single purpose.
To achieve this, I first restructured the previous video component as an abstract class, which now implements all the core functions required for a video component.
Next, I created two new components based on this abstract class:
VideoConference
: retains the same properties and behaviors as the original component, including events, methods, and callbacks.VideoMeeting
: the newly proposed component, specifically for video conferencing.Both components use the VideoComponent abstract class as their foundation.
Looking ahead, the idea is to keep the core functionalities within the abstract class while gradually moving component-specific logic to individual classes, making the code more modular and easier to maintain.
The suggested video meeting class parameters: