Index intermediate classes of GameObjects, try two #3009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusGuy
approved these changes
Jul 9, 2024
tobbi
approved these changes
Jul 10, 2024
This allows for much more efficient implementations of GameObjectManager's get_object_count and get_objects_by_type. Now, for example, counting all BadGuy objects does not require scanning through all the unrelated objects. Also, GameObjectIterator<T> can now be simplified, as it is only used on vectors which contain only objects with T as a base class.
|
I've updated this PR to account for the new Boss and BigSnowball classes, implementing |
tobbi
approved these changes
Jul 16, 2024
|
@Vankata453 Can you merge this, please? |
Vankata453
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2991 for details; in short, this significantly speeds up
GameObjectManager::get_objects_by_type()andGameObjectManager::get_object_count(), by no longer scanning over unrelated object types.However, the first version had an issue with disappearing objects with paths when a level was being tested from the level editor (#3008). I believe it was caused by the PathObject base class not being recorded in
GameObject::get_class_typesimplementations. I've updated the code to do this (and also record the other intermediate classes, TriggerBase and CollisionListener, even though those are not currently searched for.) I was able to reproduce #3008 with the old version and no longer see it with the new.