Improve cloud particles #3003
Merged
Improve cloud particles #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could someone Re-run the builds? |
|
@bruhmoent Can you rebase against latest master? That'll cause the builds to be rerun. |
Frostwithasideofsalt
approved these changes
Oct 16, 2024
MatusGuy
reviewed
Oct 17, 2024
src/object/cloud_particle_system.cpp
Outdated
| void | ||
| CloudParticleSystem::apply_fog_effect(DrawingContext& context) | ||
| { | ||
| float opacity = fog_max_value * (static_cast<float>(m_current_amount) - static_cast<float>(fog_start_amount)) / (static_cast<float>(max_amount) - static_cast<float>(fog_start_amount)); |
There was a problem hiding this comment.
What's going on with all the casting? These are floats. Is it because they're const? Constants should go to the top of this cpp file and should be marked constexpr and should be written in UPPER_CASE instead.
There was a problem hiding this comment.
Iirc I had some sort of warning that made VS refuse to compile
MatusGuy
approved these changes
Oct 25, 2024
Frostwithasideofsalt
approved these changes
Nov 7, 2024
|
thought i had reviewed this earlier. |
|
Luckily, the CI failure was unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR reopened due to simplesquirrel.
This PR: