Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yeti behavior #2969

Merged
merged 19 commits into from
Jul 10, 2024
Merged

Update yeti behavior #2969

merged 19 commits into from
Jul 10, 2024

Conversation

weluvgoatz
Copy link
Member

@weluvgoatz weluvgoatz commented Jun 11, 2024

This PR contains probably one of the final big features for 0.7.0, which is the revamp of the yeti, to fit the standards set in place by the other aspects of the game. Here is a todo list:

  • Add pinch mode
  • Put the lives, display HUD and pinch mode activation behavior into a general "Boss" class that the Yeti and Ghost Tree inherit from
  • Revamp Yeti for code quality
  • Can't spam hit Yeti, it grabs and throws you away
  • Re-add yeti snowball throwing

Discussion for this PR can happen here, on Discord, or IRC, since the new actions of the bosses are up to a lot of interpretation right now.

Fixes #1083
Fixes #979

@weluvgoatz weluvgoatz added status:in-progress Progress has been done, but more is intended be done type:feature category:code category:design labels Jun 11, 2024
@weluvgoatz weluvgoatz added this to the 0.7.0 milestone Jun 11, 2024
@weluvgoatz weluvgoatz removed the status:in-progress Progress has been done, but more is intended be done label Jul 6, 2024
@weluvgoatz weluvgoatz changed the title Update boss behavior [WIP] Update yeti behavior Jul 6, 2024
@weluvgoatz weluvgoatz marked this pull request as ready for review July 6, 2024 17:27
Copy link
Member

@bruhmoent bruhmoent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well

@@ -334,19 +448,27 @@ Yeti::collision_solid(const CollisionHit& hit)
// Go to the other side after 3 jumps.
if (m_stomp_count == 3)
{
jump_down();
m_just_hit = false;
if (m_pinch_mode) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe opening brace in a new line.

if (m_pinch_mode) {
throw_big_snowballs();
}
else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

Copy link
Member

@tobbi tobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked through this, I think looking good.

@weluvgoatz weluvgoatz merged commit dc981ec into SuperTux:master Jul 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinch Mode for boss fights Restore Yeti's "throwing bouncing snowball" attack
4 participants