Fix max drop height on slopes #2812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusGuy
added
priority:medium
status:in-progress
Merged
|
Few bugs I found:
|
MatusGuy
changed the title
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
tobbi
reviewed
Aug 14, 2024
| @@ -230,7 +230,7 @@ class BadGuy : public MovingSprite, | |||
|
|
|||
| /** Returns true if we might soon fall at least @c height | |||
| pixels. Minimum value for height is 1 pixel */ | |||
| bool might_fall(int height = 1) const; | |||
| bool might_fall(int height = 1); | |||
There was a problem hiding this comment.
Can you tell me why this method is no longer const? Do we modify the object state with the changes? And if so: Could we prevent that?
There was a problem hiding this comment.
It changes m_detected_slope. I do this because I want to prevent having two raycasts at a time. So to fix that I alternate between them by checking if m_detected_slope is 0 or not.
tobbi
reviewed
Aug 14, 2024
| @@ -99,7 +99,7 @@ void WalkingBadguy::set_ledge_behavior(LedgeBehavior behavior) | |||
| break; | |||
|
|
|||
| case LedgeBehavior::SMART: | |||
| max_drop_height = static_cast<int>(get_bbox().get_width()) / 2; | |||
| max_drop_height = 16.f; | |||
There was a problem hiding this comment.
Does this number have any significance? Seems like a magic number. Just curious.
tobbi
reviewed
Aug 14, 2024
|
Left - how it acts with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example mr tree now falls off 1 tile ledges and walking badguys cant walk up some slopes