Fix granito bugs #2797

MatusGuy · 2024-02-22T23:39:07Z

TODO:

Tux cannot unduck in front of Granito
Rock Rolling and Granito don't mix (gets force pushed out of Granito hitbox)
Tux falls off Granito when going up (and maybe down?) a slope
Granito becomes a conveyor belt
Plays walking animation when landing/staying on a slope
Granito set to type "Standing" when pushed by bomb explosion never resets speed (might be better to not have them be push-able at all)
Big Tux jittering on Granito while standing on them
Granito can walks/falls through bricks+heavy bricks+rocks
Sitting Granito waves at player and remains standing afterwards (should not wave at all when sitting)

Rusty-Box · 2024-04-13T19:02:32Z

This feels forgotten about. What was the status on this?

…into granito-fixes

Rusty-Box · 2024-05-15T19:09:07Z

Just so we don't forget to fix this bug - Granito can walk through bricks+heavy bricks which is not good.
They also walk/fall through rocks.

…3032) The `Screen` abstract class now provides virtual methods for SDL and window resize events. The `Editor` and `PartcleEditor` classes now `override` the `event(const SDL_Event& ev)` method and `Editor` `override`s `on_window_resize()`. Resize events in `ScreenManager` are now handled by all `Screen`s in the stack. SDL events are only handled by the current (top) screen. Additionally, `OptionsMenu` now calls `ScreenManager::on_window_resize()` on video setting changes, instead of just calling `MenuManager::on_window_resize()`. This fixes a bug where the editor crashes on changing the "Video Resolution" and "Magnification" settings from the in-editor "Options" menu.

The add-on **Revenge in Redmond** updated for the upcoming version of SuperTux. **Update includes** - Small intro and outro (text crawl) - Old title theme + retro themed menu level - Major changes to the levels "Late Office Nights", "Get to da Choppa!" - Completely reworked "Where Is My Super Cape!?" level - Minor tweaks to all other levels --- - [x] Set `menu_retro.stl` as menu level for RiR Add-On

MatusGuy · 2024-08-10T09:00:30Z

Plays walking animation when landing/staying on a slope

Can't reproduce this one for whatever reason

Rock Rolling and Granito don't mix (gets force pushed out of Granito hitbox)

This one is really hard to pinpoint. Seems to be an object unisolid hitbox issue. I've been using giant granito to test this. Things to note:

collision is not called in GiantGranito. Can't confirm if it is in Player (but it probably isn't)
The rock rolling is implemented in a very strange way. When an enemy hits the top of the hitbox while rolling it slowly sinks down until just randomly dying. I don't see anywhere in the code where it says "if rock and going at high speed then kill enemy"
Despite the collision event not being called, CollisionSystem::collision_static/CollisionSystem::collision_static_constraints and CollisionSystem::collision_object both change tux's position in some way.

MatusGuy · 2024-08-10T09:01:07Z

Big Tux jittering on Granito while standing on them

Very inconsistent bug. Feels like a floating point error.

Brockengespenst · 2024-08-10T12:20:09Z

The rock rolling is implemented in a very strange way. When an enemy hits the top of the hitbox while rolling it slowly sinks down until just randomly dying. I don't see anywhere in the code where it says "if rock and going at high speed then kill enemy"

Could this be the line you are looking for?

supertux/src/object/player.cpp

Line 850 in 0928a4f

badguy.kill_fall();

The flag for „rock rolling“ is m_stone.

MatusGuy · 2024-08-10T12:36:14Z

Could this be the line you are looking for?

In theory this only kills enemies from below. I'll try playing around with that.

The flag for „rock rolling“ is m_stone.

I know that.

MatusGuy · 2024-08-10T19:29:20Z

Big Tux jittering on Granito while standing on them

According to my tests this has been magically fixed in this PR?

* make "[DISABLED]" translatable * remove pointless _() function call * make "{} *UPDATE*", "{} [DISABLED] *UPDATE*" and "{} [DISABLED]" translatable as single strings * remove unnecessary fmt::runtime() calls

…rTux#3031) Fixes a bug in simplesquirrel, which caused exposed class member variables to be inaccessible from Squirrel. Additionally: * Simplesquirrel now supports custom getters and setters for class member variables. Because of this, more `get_` and `set_` functions of objects now have an alternative variable, which can also be used. * All `get_` and `set_` functions which were made obsolete by member variables are now un-deprecated, because of a noticeable preference amongst scripters to keep both options available for convenience.

Makes the error handler print fatal exceptions to the command line, as well as reverts commits eacdc11 and 2d92941, which make the exception message not print out on the dialog.

Co-authored-by: Marty <[email protected]>

…uperTux#2963)" (SuperTux#3040) This reverts commit 7302e4b. RelWithDebInfo include debug data separately from the executable, which needs a debugger to be interpreted properly. The debug data does not affect stack traces generated by the program itself, but increases the executable by more than 100Mb, which is wasted if the user does not intent to run the exectuable inside a debugger. Co-authored-by: Semphris <[email protected]>

tobbi · 2024-08-29T11:54:50Z

src/supertux/sector.cpp

@@ -566,16 +566,17 @@ Sector::is_free_of_statics(float left, float top, float right, float bottom,
 }

 bool
-Sector::is_free_of_movingstatics(const Rectf& rect, const MovingObject* ignore_object) const
+Sector::is_free_of_movingstatics(const Rectf& rect, const MovingObject* ignore_object, const bool ignoreUnisolid) const


Code style: Please name the variable ignore_unisolid

Rusty-Box · 2024-08-29T13:07:43Z

Looking better and better. Found a few more things though:

Larger Rock push Granito (Big and Small) into the ground. This is actually an issue big rocks have in general with objects smaller their scale, even small rocks. This might also affect Granito stacking in that a Granito with a bigger hitbox will phase through a Granito with a smaller hitbox
Small Granito does no longer look up when you stand on them.
Walking Small Granito does not play fall animation when they fall off platforms
Granito (Big and Small) can still walk through small rocks for some reason

Fix granito pushing while sitting

a2ae613

MatusGuy marked this pull request as draft February 22, 2024 23:39

mrkubax10 added involves:functionality status:in-progress Progress has been done, but more is intended be done category:code type:bugfix Pull Requests that fix bugs. labels Feb 23, 2024

Rusty-Box added this to the 0.7.0 milestone Apr 13, 2024

MatusGuy added 6 commits April 19, 2024 20:57

Merge branch 'SuperTux:master' into granito-fixes

b19eda0

fix unable to unduck in granito

469e594

prevent granito being pushed by explosions

e5ca657

Merge branch 'SuperTux:master' into granito-fixes

e0f836c

fix going up slope with granito

9c1e5aa

Merge branch 'granito-fixes' of https://github.com/MatusGuy/supertux …

1f6c6d9

…into granito-fixes

MatusGuy and others added 7 commits June 26, 2024 11:15

Merge branch 'SuperTux:master' into granito-fixes

c2d0c6c

Merge branch 'real-master' into granito-fixes

07d70fc

Pass string as const reference in add_option

0928a4f

i've been lied to

48670aa

granito no longer waves when sitting

4aa368f

fix rockrolling under granito

a3d18c8

MatusGuy marked this pull request as ready for review August 10, 2024 19:30

MatusGuy requested a review from Rusty-Box August 10, 2024 19:30

MatusGuy requested a review from Vankata453 August 10, 2024 19:30

Narre and others added 11 commits August 11, 2024 01:08

Make "[DISABLED]" translatable (SuperTux#2980)

7efcda1

* make "[DISABLED]" translatable * remove pointless _() function call * make "{} *UPDATE*", "{} [DISABLED] *UPDATE*" and "{} [DISABLED]" translatable as single strings * remove unnecessary fmt::runtime() calls

AmbientSound now inherits MovingObject in scripting

f5535d2

Fix broken tux santa sprite (how did this slip in here)

3e0030c

Error handler: Print fatal exceptions to command line

2d92941

Fix Windows compilation after 2d92941

eacdc11

Error handler: Properly print fatal exceptions to command line

5260e65

Makes the error handler print fatal exceptions to the command line, as well as reverts commits eacdc11 and 2d92941, which make the exception message not print out on the dialog.

Add more convenience functions to Player class (SuperTux#3037)

aee3fc7

Co-authored-by: Marty <[email protected]>

Update translations

c39b073

Update translations

6376c05

tobbi reviewed Aug 29, 2024

View reviewed changes

MatusGuy added 4 commits August 29, 2024 15:12

Merge branch 'real-master' into granito-fixes

38f5005

granito look up btw im going insane

a7f76a7

play falling animation

9d7b452

WIP!!!!!!!!!!

5d9ea51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix granito bugs #2797

Fix granito bugs #2797

MatusGuy commented Feb 22, 2024 •

edited

Loading

Rusty-Box commented Apr 13, 2024

Rusty-Box commented May 15, 2024

MatusGuy commented Aug 10, 2024

MatusGuy commented Aug 10, 2024

Brockengespenst commented Aug 10, 2024

MatusGuy commented Aug 10, 2024

MatusGuy commented Aug 10, 2024

tobbi Aug 29, 2024

Rusty-Box commented Aug 29, 2024

Fix granito bugs #2797

Are you sure you want to change the base?

Fix granito bugs #2797

Conversation

MatusGuy commented Feb 22, 2024 • edited Loading

Rusty-Box commented Apr 13, 2024

Rusty-Box commented May 15, 2024

MatusGuy commented Aug 10, 2024

MatusGuy commented Aug 10, 2024

Brockengespenst commented Aug 10, 2024

MatusGuy commented Aug 10, 2024

MatusGuy commented Aug 10, 2024

tobbi Aug 29, 2024

Choose a reason for hiding this comment

Rusty-Box commented Aug 29, 2024

MatusGuy commented Feb 22, 2024 •

edited

Loading