Root Sapling (a.k.a. Corrupted Mole) #2698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: The sprites of the Root Sapling itself are still WIP and mostly serve to begin coding!
Rusty-Box
added
type:idea
type:feature
category:code
category:design
status:needs-work
This comment has been minimized.
This comment has been minimized.
…into root-sapling
Rusty-Box
added
status:in-progress
This comment was marked as off-topic.
This comment was marked as off-topic.
mrkubax10
reviewed
Mar 11, 2024
Please let this be the last bug
tobbi
reviewed
Mar 22, 2024
tobbi
approved these changes
Mar 23, 2024
Also, increase rock size + one more sprite variant (needs code adjustments!)
|
@MatusGuy I also added the slightly improved Mole graphics and one extra sprite variant for its rock that it throws. Could you code it to included that as well. I put in a single sprite file divided into three actions. |
mrkubax10
approved these changes
Mar 24, 2024
Vankata453
requested changes
Mar 24, 2024
MatusGuy
reviewed
Mar 25, 2024
| void construct(float delay = -1, bool play_sound = true); | ||
|
|
||
| enum State { STATE_HATCHING, STATE_APPEARING, STATE_RETREATING }; |
There was a problem hiding this comment.
Functions first, then enumerators and variables, so everything is fully organized.
src/badguy/root_sapling.cpp
Outdated
| @@ -158,9 +158,9 @@ RootSapling::summon_root() | |||
| (*axis) = player->get_bbox().get_bottom() + 1; | |||
|
|
|||
| bool should_summon = false; | |||
| for (TileMap* map : Sector::get().get_solid_tilemaps()) | |||
| for (TileMap* tilemap : Sector::get().get_solid_tilemaps()) | |||
There was a problem hiding this comment.
Just a more verbose variable name.
| @@ -124,8 +124,7 @@ class Sprite final | |||
| Blend get_blend() const; | |||
|
|
|||
| bool has_action (const std::string& name) const { return (m_data.get_action(name) != nullptr); } | |||
|
|
|||
| std::size_t get_actions_count() { return m_data.actions.size(); } | |||
| size_t get_actions_count() const { return m_data.actions.size(); } | |||
There was a problem hiding this comment.
Nowhere does the code specify std:: for size_t, since there is no need to. It's a nitpick but I was editing the code anyways, so...
Vankata453
requested changes
Mar 26, 2024
Vankata453
approved these changes
Mar 26, 2024
mrkubax10
removed
the
status:needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The sprites of the Root Sapling itself are still WIP and mostly serve to begin coding!
Behavior:
Root Sapling is permanently exposed, unlike Mole, and does not throw rocks. Instead Root Sapling spawns small roots pointing upwards (like Ghost Tree) underneath the player every couple seconds - one at a time. The root attack will only stop until the player either leaves its attack range or kills it by jumping on its head/core. It's attack radius would be quite large - big enough that it can roughly attacks you as long as it is on screen. 20 tiles might be enough, maybe.
Root Attack:
Underneath the player's last position, a small hill spawns (with partilces popping up to help visualizing where/when it spawned and a second after the root pokes out, retracting shortly after - then despawning. Another root may appear with a 2 second cooldown.
This enemy will (hopefully) give players a point of reference when eventually facing the Ghost Tree, as the current plan for how to damage it will be shared with Root Sapling - hitting its core by jumping on it!
Scripted Concept Video:
scripted_root_sapling_concept.mp4
TODO