Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revenge in Redmond Update #2662

Merged
merged 37 commits into from
Aug 7, 2024
Merged

Revenge in Redmond Update #2662

merged 37 commits into from
Aug 7, 2024

Conversation

Rusty-Box
Copy link
Member

@Rusty-Box Rusty-Box commented Oct 18, 2023 •
edited
Loading

The add-on Revenge in Redmond updated for the upcoming version of SuperTux.

Update includes

  • Small intro and outro (text crawl)
  • Old title theme + retro themed menu level
  • Major changes to the levels "Late Office Nights", "Get to da Choppa!"
  • Completely reworked "Where Is My Super Cape!?" level
  • Minor tweaks to all other levels
  • Set menu_retro.stl as menu level for RiR Add-On

@Rusty-Box Rusty-Box added this to the 0.7.0 milestone Oct 18, 2023
@Vankata453 Vankata453 self-assigned this Oct 18, 2023
@Rusty-Box
Copy link
Member Author

If anyone wants to check for typos etc. be my guest. Otherwise this should be ready to go!

@serano01
Copy link
Member

serano01 commented Feb 1, 2024

If this includes the retro menu level, maybe it should have the retro coin sprite for the HUD as well. Just a thought, because anywhere else it fits its theme.

@mrkubax10
Copy link
Member

If this includes the retro menu level, maybe it should have the retro coin sprite for the HUD as well. Just a thought, because anywhere else it fits its theme.

Currently custom HUD is not supported so I would leave that for future/another PR.

tobbi
tobbi requested changes Feb 6, 2024
View reviewed changes
data/levels/revenge_in_redmond/intro.txt Outdated Show resolved Hide resolved
data/levels/revenge_in_redmond/intro.txt Outdated Show resolved Hide resolved
data/levels/revenge_in_redmond/intro.txt Outdated Show resolved Hide resolved
@Vankata453
Copy link
Member

You don't even die here I don't see this as an issue really.

I think it just looks off for the ground to end like that, especially when this doesn't happen in other levels.

@NickerAban
Copy link

wow

@tobbi
Copy link
Member

tobbi commented Jul 7, 2024

One thing I noticed in "Where is this Gown": The secret at the very beginning - should it not have a fade tilemap?

@tylerandari13
Copy link
Contributor

One thing I noticed in "Where is this Gown": The secret at the very beginning - should it not have a fade tilemap?

I think the secrets work the way they do so that they look like secrets from Milestone 1.

@tobbi
Copy link
Member

tobbi commented Jul 7, 2024 •
edited
Loading

One thing I noticed in "Where is this Gown": The secret at the very beginning - should it not have a fade tilemap?

I think the secrets work the way they do so that they look like secrets from Milestone 1.

Ah, probably. One more thing I noticed is that the menu level gets overriden by physfs that way.

tobbi
tobbi approved these changes Jul 7, 2024
View reviewed changes
Copy link
Member

@tobbi tobbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Frostwithasideofsalt
Frostwithasideofsalt suggested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Frostwithasideofsalt Frostwithasideofsalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The levelset shows up in the user levels for some reason, and transparent up isn't used on the title screen.

@Rusty-Box
Copy link
Member Author

The levelset shows up in the user levels for some reason, and transparent up isn't used on the title screen.

Fixed

@Frostwithasideofsalt
Copy link
Member

@MatusGuy could it possible for you to schedule this PR to be merged?

Vankata453
Vankata453 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@Vankata453 Vankata453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't played the world again after the latest commits but I remember everything else was fine from my last playthrough, so it should be good to go.

@epicguy2222
Copy link

i like how some of the levels reference or are based on milestone 1 levels

@MatusGuy MatusGuy merged commit fefc0b0 into SuperTux:master Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostwithasideofsalt Frostwithasideofsalt Frostwithasideofsalt requested changes

@Vankata453 Vankata453 Vankata453 approved these changes

@mrkubax10 mrkubax10 mrkubax10 approved these changes

@weluvgoatz weluvgoatz weluvgoatz approved these changes

@tobbi tobbi tobbi approved these changes

Assignees

@Vankata453 Vankata453

Labels
category:levels status:needs-review Work needs to be reviewed by other people type:level type:patch
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.