Granito NPC for Rooted Forest #2635
Conversation
Add images/creatures/granito along side a couple sprites. More to come!
They are not ready yet! Added them previously by accident
Rusty-Box
added
status:in-progress
|
@MatusGuy wanted to work on the coding side of things! |
|
i have no idea how i managed to not include granito.hpp in the commit |
This comment has been minimized.
This comment has been minimized.
Includes animation for standing and walking [ci skip]
…nto granito-npc
This comment has been minimized.
This comment has been minimized.
|
src/badguy/granito.hpp
Outdated
| #ifndef GRANITO_H | ||
| #define GRANITO_H |
There was a problem hiding this comment.
Wrong header guard naming, also missing license info. (Same in granito.cpp)
There was a problem hiding this comment.
On the coding side, this PR seems to be very WIP so reviewing it now may be pointless.
There was a problem hiding this comment.
Yeah I know, but I want to point out the obvious things.
There was a problem hiding this comment.
still thanks for warning. Qt creator usually just does default
There was a problem hiding this comment.
There's also other issues I notice on the surface, but would keep those for when it's ready for review.
|
little reference to minecrafk villagers |
|
:snowsmiley: |
This comment has been minimized.
This comment has been minimized.
|
they may be uploaded when they're ready |
This comment has been minimized.
This comment has been minimized.
|
Giant Granito is still kill-able. Please fix :) |
…nto granito-npc
|
why is it taking to long for them to get added? |
Their never getting added, because nolok killed them all! So sad. |
|
They're not getting added because vincent stole industrial assets |
They are rather intricite and require a lot of tweaking and fixing since we never had a NPC type object/character in the game. There is also many other places we gotta work on so sometimes stuff falls behind, getting pickup later. Stay patient will you. |
|
@Vankata453 Marty told me awhile ago he may need your help with making Granito scriptable, when you have time that is. |
|
@Rusty-Box The |
|
Agree. Meanwhile, could you review the granito code? |
Great. So let's get this thing reviewed and work on the scripting after alongside the API thing then |
src/badguy/granito.cpp
Outdated
| // yo big granito can i sit on top of your head? | ||
| GranitoBig* granito = dynamic_cast<GranitoBig*>(&other); | ||
|
|
||
| if (!granito) | ||
| { | ||
| // i'm not a granito | ||
| return WalkingBadguy::collision(other, hit); | ||
| } | ||
|
|
||
| if (granito->m_carrying != nullptr) | ||
| { | ||
| // sorry im already carrying this guy | ||
| return WalkingBadguy::collision(other, hit); | ||
| } | ||
|
|
||
| // sure dude | ||
| granito->m_carrying = this; | ||
|
|
||
| // yay | ||
| m_state = STATE_SIT; |
There was a problem hiding this comment.
Comments are fine, could follow the convention of uppercase first letter though (and preferably, an end-of-sentence mark).
src/badguy/granito.hpp
Outdated
| bool m_stepped_on; /** true if tux was on top of granito last frame */ | ||
| bool m_airborne; /** unfortunately on_ground() sucks */ |
|
why are the granitos only on the linux version of supertux and not the windows version? |
|
at last the granitos have arrived :'D |
|
idk how many will take for them to add in the windows edition of supertux |
mrkubax10
removed
the
status:needs-review
Granito will be a friendly npc withi Rooted Forest levels. There are 3 variants planned, the small, big and giant Granito.
Small Granito:
The default variant, small Granito walk around randomly ocassionally stopping and looking around a bit and some may sit on the ground. They are also semi-smart, i.e. if there is ave ground to stand, they will drop of ledges otherwise they will simply turn around. If there is a wall in their path and the wall is low enough, they will jump over it! Otherwise, again, they just turn around.
And as a little bonus, if they see Tux close by they will also wave at him once and look up at the player if he stand on-top of their head :)
Big Granito: (sprites incomplete)
Big Granito are just a bigger version of Granito behaving the same as their small counterpart. The difference being they are a smart object, i.e. they do not walk of ledges! They also cannot jump. They do not wave at Tux.
Giant Granito: (sprites incomplete)
Giant Granito are merely meant as a background object. They simply sit around and don't really react to anything happening.
Note: All types of Granito, Tux can stand on but also walk past them, making them basically unisolid.
"Proof-of-concept" of small Granito behavior video, using scripted Objects:
granito_small_concept.mp4
TODO (Graphics)
TODO (Code - need help)