Crystallo <-> Roof Crystallo on levelflip #2576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrystallo (awake) -> rcrystallo on levelflip scrystallo (sleeping) flips its texture on levelflip waking scrystallo during levelflip -> rcrystallo (attacking)
fix bug with Direction::AUTO in the editor for scrystallo and rcrystallo
mrkubax10
added
involves:functionality
category:code
status:needs-review
tobbi
reviewed
Aug 14, 2023
mrkubax10
approved these changes
Aug 16, 2023
Vankata453
reviewed
Aug 16, 2023
tobbi
approved these changes
Aug 16, 2023
Vankata453
approved these changes
Aug 16, 2023
mrkubax10
removed
the
status:needs-review
Rusty-Box
pushed a commit
that referenced
this pull request
Aug 25, 2023
…#2588) This adds back the missing jumping sprite actions for crystallo (I accidentally removed them in #2576 ). It also re-disables gravity for Sleeping Crystallo, which I enabled in the same PR, but apparently, there is a legitimate use case and a reason for why it was disabled before, so I'm re-disabling it. The gravity will also be disabled for Roof Crystallos created by waking roof-attached Sleeping Crystallos (until they drop).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Crystallos transform into Roof Crystallos on levelflip() (and vice versa).
Awaken Sleeping Crystallos get transformed into Roof Crystallos too.
Asleep Sleeping Crystallos get their texture flipped.
If awaken during a levelflip(), the Sleeping Crystallo will transform into a Roof Crystallo and immediately drop/attack.
This PR also combines
crystallo.sprite,scrystallo.spriteandrcrystallo.spriteinto one (crystallo.sprite) sprite file. This is done so that the crystallos can keep their sprite during the transformations, i.e. compatibility with custom sprites.crystalflip.mp4