Display world screenshot previews and progress #2349
Conversation
mrkubax10
added
type:feature
category:code
status:needs-review
Vankata453
force-pushed
the
world-previews
branch
from
537410d
to
41bed28
Compare
|
This PR is now ready for review. |
There was a problem hiding this comment.
Is completing all levels normally supposed to count as 100%? What about getting all collectibles?
On small screens, the help text is not fully readable because it's not aligned to the screen but rather to the menu.
I don't see any animations when navigating a Filesystem menu.
Aside from that, nice work!
That is only supposed to indicate the progress through levels on the map. If the percentage isn't perceived well, I can remove it.
True, it should stay centered regardless.
Do you have transitions enabled? |
Yes, but now that I think about it, this might be because the loading time overrides the animation. That can be something for another pr. Will do some further investigation later. The preview still gets squished. I cloned this PR and am currently trying to write a fix for this |
Yes, if you go to the next item too quickly, there will be no time for animations.
It does, but only if you change your resolution to be different from the one when the screenshot was taken. |
Co-authored-by: Marty <[email protected]>
|
Hi back, I'm dad. If I remember correctly, I remember that this PR didn't show the right aspect ratio for the source image when the screen resolution was smaller than the source picture... Something along those lines. |
There was a problem hiding this comment.
This feature works well and I am satisfied with the current implementation. One suggestion I have, though, is to make it so that the screenshot gets taken before the player presses the escape key, so that every screenshot doesn't have the escape menu in it. For example, the player presses escape -> take screenshot -> show escape menu.
|
It shows the menu? It's supposed to hide whenever the screenshot is being taken. |
|
my one thing with this pr is how it displays the stats when theirs no preview image. it's really ugly, unclear and overwhelming. it would be much preferred if the stats just showed up like this if there wasnt any image to go along with it |
|
because of that it also tends to send stuff off the screen. it also seems to show the wrong level count for some reason? like in this image it says the bonus island remake has 60 levels when it only has 30. what i think whats happening is that it's counting the number of files in the level folder and using that for the level count, even if it's not a level file ...? im not too sure. but the number of levels it reports has so far been equal to the amount of files in the level folder. so yeah. |
There was a problem hiding this comment.
Even if that isn't the cause- there's for sure something inflating the level count by a lot. so the things im suggesting are:
-make level stats for a world without a screenshot display similarly to how their displayed when their is a screenshot
-fix the bug inflating level counts
I dont think there would be a genuine way to fix this without refactoring the menus a bit using a scrollbar system of some sort. iirc this behavior is pretty poorly baked in. Best hack of a fix for now would be truncating long lines if we just wanna ship it as is. |
WorldSetMenuandSortedContribMenunow inherit the newWorldPreviewMenuclass, which allows displaying profile-specific world previews and progress. A preview for a world is generated each time the user leaves its worldmap. Only worldmap levelsets support this feature.Supported also are optional placeholder world previews, which have to be named
preview.png, and stored in the relative tolevelsdirectory for the world.FileSystemMenualso now shows previews of images, when hovering over an image file.