Revert "Index by base classes in GameObjectManager::m_objects_by_type…

…_index (#2991)" This reverts commit df670e4.
SuperTux · Jul 8, 2024 · 15a29c6 · 15a29c6
1 parent 47541be
commit 15a29c6
Show file tree

Hide file tree

Showing 181 changed files with 35 additions and 249 deletions.
diff --git a/src/badguy/angrystone.hpp b/src/badguy/angrystone.hpp
@@ -38,7 +38,6 @@ class AngryStone final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Angry Stone"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(AngryStone)); }
 
 protected:
   virtual std::vector<Direction> get_allowed_directions() const override;

diff --git a/src/badguy/badguy.hpp b/src/badguy/badguy.hpp
@@ -68,7 +68,6 @@ class BadGuy : public MovingSprite,
   virtual std::string get_exposed_class_name() const override { return "BadGuy"; }
   static std::string display_name() { return _("Badguy"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return MovingSprite::get_class_types().add(typeid(Portable)).add(typeid(BadGuy)); }
 
   virtual std::string get_overlay_size() const { return "1x1"; }
 

diff --git a/src/badguy/bomb.hpp b/src/badguy/bomb.hpp
@@ -25,7 +25,6 @@ class Bomb final : public BadGuy
 {
 public:
   Bomb(const Vector& pos, Direction dir, const std::string& custom_sprite = "images/creatures/mr_bomb/bomb.sprite" );
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Bomb)); }
   virtual bool is_saveable() const override {
     return false;
   }

diff --git a/src/badguy/bouncing_snowball.hpp b/src/badguy/bouncing_snowball.hpp
@@ -38,7 +38,6 @@ class BouncingSnowball final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Bouncing Snowball"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(BouncingSnowball)); }
 
   virtual GameObjectTypes get_types() const override;
   virtual std::string get_default_sprite_name() const override;

diff --git a/src/badguy/captainsnowball.hpp b/src/badguy/captainsnowball.hpp
@@ -31,7 +31,6 @@ class CaptainSnowball final : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Captain Snowball"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(CaptainSnowball)); }
   virtual bool is_snipable() const override { return true; }
 
   bool might_climb(int width, int height) const;

diff --git a/src/badguy/corrupted_granito.hpp b/src/badguy/corrupted_granito.hpp
@@ -43,7 +43,6 @@ class CorruptedGranito final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Corrupted Granito"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(CorruptedGranito)); }
   virtual bool is_snipable() const override { return true; }
   virtual bool is_flammable() const override { return m_type != GRANITO; }
 

diff --git a/src/badguy/corrupted_granito_big.hpp b/src/badguy/corrupted_granito_big.hpp
@@ -34,7 +34,6 @@ class CorruptedGranitoBig final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Corrupted Big Granito"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(CorruptedGranitoBig)); }
 
   virtual bool is_snipable()  const override { return false; }
   virtual bool is_freezable() const override { return false; }

diff --git a/src/badguy/crusher.hpp b/src/badguy/crusher.hpp
@@ -70,7 +70,6 @@ class Crusher final : public MovingSprite
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Crusher"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return MovingSprite::get_class_types().add(typeid(Crusher)); }
 
   virtual ObjectSettings get_settings() override;
   GameObjectTypes get_types() const override;
@@ -116,7 +115,6 @@ class CrusherRoot : public MovingSprite
 {
 public:
   CrusherRoot(Vector position, Crusher::Direction direction, float delay, int layer);
-  virtual GameObjectClasses get_class_types() const override { return MovingSprite::get_class_types().add(typeid(CrusherRoot)); }
 
   virtual HitResponse collision(GameObject& other, const CollisionHit& hit) override;
   virtual void update(float dt_sec) override;

diff --git a/src/badguy/crystallo.hpp b/src/badguy/crystallo.hpp
@@ -32,7 +32,6 @@ class Crystallo final : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Crystallo"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(Crystallo)); }
 
   virtual void active_update(float dt_sec) override;
   virtual bool is_flammable() const override;

diff --git a/src/badguy/dart.hpp b/src/badguy/dart.hpp
@@ -43,7 +43,6 @@ class Dart final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Dart"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Dart)); }
 
   virtual bool is_flammable() const override;
 

diff --git a/src/badguy/darttrap.hpp b/src/badguy/darttrap.hpp
@@ -34,7 +34,6 @@ class DartTrap final : public StickyBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Dart Trap"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return StickyBadguy::get_class_types().add(typeid(DartTrap)); }
 
   virtual ObjectSettings get_settings() override;
   virtual GameObjectTypes get_types() const override;

diff --git a/src/badguy/dispenser.hpp b/src/badguy/dispenser.hpp
@@ -66,7 +66,6 @@ class Dispenser final : public BadGuy
   virtual std::string get_exposed_class_name() const override { return "Dispenser"; }
   static std::string display_name() { return _("Dispenser"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Dispenser)); }
 
   virtual ObjectSettings get_settings() override;
   virtual GameObjectTypes get_types() const override;

diff --git a/src/badguy/dive_mine.hpp b/src/badguy/dive_mine.hpp
@@ -49,7 +49,6 @@ class DiveMine final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Dive Mine"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(DiveMine)); }
 
 protected:
   virtual std::vector<Direction> get_allowed_directions() const override;

diff --git a/src/badguy/fish_chasing.hpp b/src/badguy/fish_chasing.hpp
@@ -33,7 +33,6 @@ class FishChasing final : public FishSwimming
   static std::string display_name() { return _("Chasing Fish"); }
   virtual std::string get_display_name() const override { return display_name(); }
   virtual std::string get_overlay_size() const override { return "2x2"; }
-  virtual GameObjectClasses get_class_types() const override { return FishSwimming::get_class_types().add(typeid(FishChasing)); }
   virtual ObjectSettings get_settings() override;
 
   std::string get_default_sprite_name() const override;

diff --git a/src/badguy/fish_harmless.hpp b/src/badguy/fish_harmless.hpp
@@ -29,7 +29,6 @@ class FishHarmless final : public FishSwimming
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Harmless Fish"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return FishSwimming::get_class_types().add(typeid(FishHarmless)); }
   virtual std::string get_overlay_size() const override { return "1x1"; }
 
   GameObjectTypes get_types() const override { return {}; }

diff --git a/src/badguy/fish_jumping.hpp b/src/badguy/fish_jumping.hpp
@@ -40,7 +40,6 @@ class FishJumping final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Jumping Fish"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(FishJumping)); }
 
 protected:
   virtual std::vector<Direction> get_allowed_directions() const override;

diff --git a/src/badguy/fish_swimming.hpp b/src/badguy/fish_swimming.hpp
@@ -40,7 +40,6 @@ class FishSwimming : public BadGuy
   static std::string display_name() { return _("Swimming Fish"); }
   virtual std::string get_display_name() const override { return display_name(); }
   virtual std::string get_overlay_size() const override { return "2x1"; }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(FishSwimming)); }
   virtual ObjectSettings get_settings() override;
 
   virtual GameObjectTypes get_types() const override;

diff --git a/src/badguy/flame.hpp b/src/badguy/flame.hpp
@@ -46,7 +46,6 @@ class Flame final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Flame"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Flame)); }
 
   virtual void stop_looping_sounds() override;
   virtual void play_looping_sounds() override;

diff --git a/src/badguy/flyingsnowball.hpp b/src/badguy/flyingsnowball.hpp
@@ -32,7 +32,6 @@ class FlyingSnowBall final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Flying Snowball"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(FlyingSnowBall)); }
   virtual bool is_snipable() const override { return true; }
 
 protected:

diff --git a/src/badguy/ghosttree.hpp b/src/badguy/ghosttree.hpp
@@ -42,7 +42,6 @@ class GhostTree final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Ghost Tree"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(GhostTree)); }
 
   virtual void on_flip(float height) override;
 

diff --git a/src/badguy/ghoul.hpp b/src/badguy/ghoul.hpp
@@ -30,7 +30,6 @@ class Ghoul final : public BadGuy,
   static std::string display_name() { return _("Ghoul"); }
   std::string get_class_name() const override { return class_name(); }
   std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Ghoul)); }
   bool is_freezable() const override;
   bool is_flammable() const override;
   virtual bool is_snipable() const override { return true; }

diff --git a/src/badguy/goldbomb.hpp b/src/badguy/goldbomb.hpp
@@ -49,7 +49,6 @@ class GoldBomb final : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Gold Bomb"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(GoldBomb)); }
   virtual bool is_snipable() const override { return true; }
 
   virtual void stop_looping_sounds() override;

diff --git a/src/badguy/granito.hpp b/src/badguy/granito.hpp
@@ -51,7 +51,6 @@ class Granito : public WalkingBadguy
   virtual std::string get_exposed_class_name() const override { return "Granito"; }
   static std::string display_name() { return _("Granito"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(Granito)); }
 
   virtual bool is_snipable() const override { return false; }
   virtual bool is_freezable() const override { return false; }

diff --git a/src/badguy/granito_big.hpp b/src/badguy/granito_big.hpp
@@ -43,7 +43,6 @@ class GranitoBig final : public Granito
   virtual std::string get_exposed_class_name() const override { return "GranitoBig"; }
   static std::string display_name() { return _("Big Granito"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return Granito::get_class_types().add(typeid(GranitoBig)); }
 
   virtual ObjectSettings get_settings() override;
   virtual GameObjectTypes get_types() const override;

diff --git a/src/badguy/granito_giant.hpp b/src/badguy/granito_giant.hpp
@@ -31,7 +31,6 @@ class GranitoGiant final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Giant Granito"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(GranitoGiant)); }
 
   virtual void kill_fall() override;
 

diff --git a/src/badguy/haywire.hpp b/src/badguy/haywire.hpp
@@ -45,7 +45,6 @@ class Haywire final : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Haywire"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(Haywire)); }
   virtual bool is_snipable() const override { return true; }
 
   inline bool is_exploding() const { return m_is_exploding; }

diff --git a/src/badguy/igel.hpp b/src/badguy/igel.hpp
@@ -38,7 +38,6 @@ class Igel final : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Igel"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(Igel)); }
 
   virtual bool is_freezable() const override { return true; }
   virtual void unfreeze(bool melt = true) override;

diff --git a/src/badguy/jumpy.hpp b/src/badguy/jumpy.hpp
@@ -39,7 +39,6 @@ class Jumpy final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Jumpy"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Jumpy)); }
 
   GameObjectTypes get_types() const override;
   std::string get_default_sprite_name() const override;

diff --git a/src/badguy/kamikazesnowball.hpp b/src/badguy/kamikazesnowball.hpp
@@ -33,7 +33,6 @@ class KamikazeSnowball : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Kamikaze Snowball"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(KamikazeSnowball)); }
   virtual bool is_snipable() const override { return true; }
 
 protected:
@@ -64,7 +63,6 @@ class LeafShot final : public KamikazeSnowball
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Leafshot"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return KamikazeSnowball::get_class_types().add(typeid(LeafShot)); }
 
   virtual bool is_snipable() const override { return true; }
 

diff --git a/src/badguy/kugelblitz.hpp b/src/badguy/kugelblitz.hpp
@@ -39,7 +39,6 @@ class Kugelblitz final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Kugelblitz"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Kugelblitz)); }
 
   void explode();
 

diff --git a/src/badguy/livefire.hpp b/src/badguy/livefire.hpp
@@ -37,7 +37,6 @@ class LiveFire : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Walking Flame"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(LiveFire)); }
 
 private:
   std::string death_sound;
@@ -71,7 +70,6 @@ class LiveFireAsleep final : public LiveFire
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Sleeping Flame"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return LiveFire::get_class_types().add(typeid(LiveFireAsleep)); }
 
 private:
   LiveFireAsleep(const LiveFireAsleep&) = delete;
@@ -90,7 +88,6 @@ class LiveFireDormant final : public LiveFire
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Dormant Flame"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return LiveFire::get_class_types().add(typeid(LiveFireDormant)); }
 
 private:
   LiveFireDormant(const LiveFireDormant&) = delete;

diff --git a/src/badguy/mole.hpp b/src/badguy/mole.hpp
@@ -37,7 +37,6 @@ class Mole final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Mole"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(Mole)); }
 
   virtual bool is_snipable() const override { return true; }
 

diff --git a/src/badguy/mole_rock.hpp b/src/badguy/mole_rock.hpp
@@ -43,7 +43,6 @@ class MoleRock final : public BadGuy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Mole's rock"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return BadGuy::get_class_types().add(typeid(MoleRock)); }
 
 protected:
   const BadGuy* parent; /**< collisions with this BadGuy will be ignored */

diff --git a/src/badguy/mrbomb.hpp b/src/badguy/mrbomb.hpp
@@ -39,7 +39,6 @@ class MrBomb final : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Mr. Bomb"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(MrBomb)); }
   virtual bool is_snipable() const override { return true; }
 
   GameObjectTypes get_types() const override;

diff --git a/src/badguy/mriceblock.hpp b/src/badguy/mriceblock.hpp
@@ -48,7 +48,6 @@ class MrIceBlock : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Mr. Iceblock"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(MrIceBlock)); }
 
   virtual bool is_snipable() const override { return ice_state != ICESTATE_KICKED; }
   virtual bool is_freezable() const override;

diff --git a/src/badguy/mrtree.hpp b/src/badguy/mrtree.hpp
@@ -31,7 +31,6 @@ class MrTree final : public WalkingBadguy
   virtual std::string get_class_name() const override { return class_name(); }
   static std::string display_name() { return _("Mr. Tree"); }
   virtual std::string get_display_name() const override { return display_name(); }
-  virtual GameObjectClasses get_class_types() const override { return WalkingBadguy::get_class_types().add(typeid(MrTree)); }
 
   GameObjectTypes get_types() const override;
   std::string get_default_sprite_name() const override;