-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config command #112
Draft
SIMULATAN
wants to merge
18
commits into
SuperCuber:master
Choose a base branch
from
SIMULATAN:feat/config-command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Add config command #112
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ed5b8d4
Add config command
SIMULATAN 31d0b8f
[POC] print packages as a tree
SIMULATAN 07b5559
[POC] only show enabled packages, fix name
SIMULATAN a26292c
Move dependencies to root item
SIMULATAN 99961ff
Fix clippy & readme issues
SIMULATAN 487c6d6
Change dependencies to be a list rather than tree
SIMULATAN f429fe6
Fix clippy
SIMULATAN cb32509
Break up `config` function into smaller functions
SIMULATAN 96cf587
Dialog: package names as summary text
SIMULATAN 2188c79
Gray out dependency information
SIMULATAN 9b761b8
Display transitive dependencies on start
SIMULATAN 94b5bed
Update transitive dependencies when selecting items
SIMULATAN 9783900
Minor code cleanup
SIMULATAN 7ffdcf5
Fix clippy issues
SIMULATAN d9bcf94
Cleanup & rewrite of some logic
188fe10
Merge branch 'master' into current
889e30e
Bring back dialoguer
69ee575
Fix todos
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crates.io does not allow git dependencies :(
We might have to get your changes merged into
dialoguer
, is there a reason you haven't opened a PR?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main reason is that I kinda just haven't gotten around to it, especially since it wasn't fully approved yet.
However, that isn't the only problem:
My changes are vastly different from what the library usually stands for. While the other components aren't exactly configurable, this one very much is and thus seems a bit out of place (and therefore possibly out of scope).
Additionally, the code is kinda messy and the change is pretty large (~500 lines, although the majority of that is because I created a separate
multi_select_plus
component rather than editing the existing one).Let's just say, I'm not exactly confident in my rust skills (I mean, just looking at your cleanup, it appears I made quite a few mistakes 😅)
To get an idea of the changes, see the diff
Considering that reasoning, I'll try to see if I can get something going that would have a chance at getting merged upstream, both in terms of code quality and "genericness". As I said a while back, right now, it's very opinionated, having only what's necessary for this feature to work (in particular, the callback feature).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I'm sure
dialoguer
's maintainer will have comments to steer you in the right direction :)Please link the PR here when you open one