Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SumoLogicAppenderTest cleanup and new tests for SumoLogicAppender.newBuilder() #52

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

raphisuter
Copy link
Contributor

I did some small improvements in README.md (add borders/pipe symbols) to all table rows, cleaned up some unnecessary code in SumoLogicAppenderTest and wrote some new tests for the builder of SumoLogicAppender. There were also some occurrences left of hardcoded newLine characters \n in the tests which have been cleaned up as well. (see #51)

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +39.23% 🎉

Comparison is base (a820c53) 38.46% compared to head (de3f65e) 77.69%.
Report is 18 commits behind head on master.

❗ Current head de3f65e differs from pull request most recent head d8d0101. Consider uploading reports for the commit d8d0101 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##             master      #52       +/-   ##
=============================================
+ Coverage     38.46%   77.69%   +39.23%     
- Complexity        7       10        +3     
=============================================
  Files             1        1               
  Lines           130      130               
  Branches          2        2               
=============================================
+ Hits             50      101       +51     
+ Misses           76       27       -49     
+ Partials          4        2        -2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mccartney
Copy link
Contributor

Thanks a lot of for this contribution.

@mccartney mccartney merged commit 1941cc7 into SumoLogic:master Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants