Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Game]:want to Add New Game Dante !! #2474 #2477

Merged
merged 4 commits into from
Jul 21, 2024

Conversation

nishant0708
Copy link
Contributor

@nishant0708 nishant0708 commented Jul 21, 2024

Description

Added New Game Dante

Fixes: #2474

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [X ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • [X ] I have made this from my own
  • [ X] I have taken help from some online resourses
  • [ X] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my own code
  • [ X] I have commented my code, particularly in hard-to-understand areas
  • [ X] I have made corresponding changes to the documentation
  • [ X] My changes generate no new warnings

ATTACH SCREEN-SHOTS / DEPLOYMENT LINK

Uploading Screenshot 2024-07-21 053109.png…

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link
Owner

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly add manifest files @nishant0708

@nishant0708
Copy link
Contributor Author

@Sulagna-Dutta-Roy Added Mam

Copy link
Owner

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json and manifest.json is totally different. You have added react package, kindly check again @nishant0708

@nishant0708
Copy link
Contributor Author

please check now mam i guess it should work now

Copy link
Owner

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly delete the package.json it's not needed @nishant0708

@nishant0708
Copy link
Contributor Author

Done mam @Sulagna-Dutta-Roy

@Sulagna-Dutta-Roy Sulagna-Dutta-Roy merged commit e2cbd4c into Sulagna-Dutta-Roy:master Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Game]:want to Add New Game Dante !!
2 participants