Fixed fireworks not detonating on 1.12.2

Detonation needed to be scheduled. Also slightly increased the default firework arrow speed.
SugarCaney · Mar 21, 2022 · 77d76f7 · 77d76f7
1 parent c2ebadc
commit 77d76f7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/main/kotlin/nl/sugcube/dirtyarrows/bow/ability/FireworkBow.kt b/src/main/kotlin/nl/sugcube/dirtyarrows/bow/ability/FireworkBow.kt
@@ -5,6 +5,7 @@ import nl.sugcube.dirtyarrows.bow.BowAbility
 import nl.sugcube.dirtyarrows.bow.DefaultBow
 import nl.sugcube.dirtyarrows.util.ColourScheme
 import nl.sugcube.dirtyarrows.util.fuzz
+import nl.sugcube.dirtyarrows.util.scheduleDelayed
 import nl.sugcube.dirtyarrows.util.showColoredDust
 import org.bukkit.*
 import org.bukkit.entity.*
@@ -213,7 +214,10 @@ open class FireworkBow(plugin: DirtyArrows) : BowAbility(
 
  addEffect(effectBuilder.build())
  }
- detonate()
+
+ plugin.scheduleDelayed(1) {
+ detonate()
+ }
  }
  }
 

diff --git a/src/main/resources/config.yml b/src/main/resources/config.yml
@@ -1998,8 +1998,8 @@ firework:
  # Settings for the main projectile: the one you fire from your bow.
  main:
  # The maximum speed the main firework projectiles can move.
- # (Double) default: 1.25
- maximum-speed: 1.25
+ # (Double) default: 1.4
+ maximum-speed: 1.4
 
  # The amount of milliseconds the main projectile flies before splitting into multiple projectiles.
  # (Int) default: 1450