Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket - Add events (OnConnect / OnDisconnect) #86

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Websocket - Add events (OnConnect / OnDisconnect) #86

wants to merge 7 commits into from

Conversation

Apolixit
Copy link
Member

@Apolixit Apolixit commented Jul 9, 2024

Linked to #83

@Apolixit Apolixit added the enhancement New feature or request label Jul 9, 2024
@Apolixit
Copy link
Member Author

Apolixit commented Jul 9, 2024

@RostislavLitovkin, based on your issue, I have added OnConnect and OnDisconnect, but I didn't implemented the others because I think it is better if it is handle by the caller (maybe some apps doesn't want auto-reconnect)

You can try this PR on your app before to merge if you prefer ;)

darkfriend77
darkfriend77 requested changes Jul 16, 2024
View reviewed changes
Copy link
Member

@darkfriend77 darkfriend77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure that we use the events from the integrated frameworks like vs-streamjsonrpc and the websocket it self, there is also the underlying httpclient maybe.

Substrate.NetApi/SubstrateClient.cs Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 14, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkfriend77 darkfriend77 darkfriend77 requested changes

@RostislavLitovkin RostislavLitovkin RostislavLitovkin approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apolixit @darkfriend77 @RostislavLitovkin