-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve vehicle destruction sync #2197
base: master
Are you sure you want to change the base?
Improve vehicle destruction sync #2197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGCW. Good to have it moved over to the new system and remove code complexity
Cyclops wrecks are also synced now |
Works fine IG :
Bugs we noticed :
|
Both of these should be fixed now. |
NitroxClient/GameLogic/Spawning/WorldEntities/VehicleWorldEntitySpawner.cs
Outdated
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/CyclopsDestructionEvent_SpawnLootAsync_Patch.cs
Outdated
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/CyclopsDestructionEvent_SpawnLootAsync_Patch.cs
Show resolved
Hide resolved
NitroxPatcher/Patches/Dynamic/SubRoot_SetCyclopsUpgrades_Patch.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SubRoot_SetCyclopsUpgrades_Patch.cs#L18
you have the return in the same line. Nitrox code style normally says that we do brackets for every if.
Besides that LGTM CW
Properly moves vehicle destroying to the new entities system.