Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vehicle destruction sync #2197

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

SpaceMonkeyy86
Copy link
Contributor

Properly moves vehicle destroying to the new entities system.

Copy link
Collaborator

@Coding-Hen Coding-Hen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGCW. Good to have it moved over to the new system and remove code complexity

@SpaceMonkeyy86
Copy link
Contributor Author

Cyclops wrecks are also synced now

@dartasen
Copy link
Member

Works fine IG :

  • We can see seamoth & exosuit being destroyed
  • We can see cyclops exploding
  • Wrecks are still here upon re-joining (with items, upgrades in it)

Bugs we noticed :

  • Wrecks will re-explode upon re-joining
  • Decoys slots are gone upon re-joining

@SpaceMonkeyy86 SpaceMonkeyy86 changed the title Fix vehicle destroy not syncing Improve vehicle destruction sync Nov 18, 2024
@SpaceMonkeyy86
Copy link
Contributor Author

Works fine IG :

* We can see seamoth & exosuit being destroyed

* We can see cyclops exploding

* Wrecks are still here upon re-joining (with items, upgrades in it)

Bugs we noticed :

* Wrecks will re-explode upon re-joining

* Decoys slots are gone upon re-joining

Both of these should be fixed now.

Copy link
Member

@Jannify Jannify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In SubRoot_SetCyclopsUpgrades_Patch.cs#L18 you have the return in the same line. Nitrox code style normally says that we do brackets for every if.

Besides that LGTM CW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants