Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor:RainbowGrades] Remove benchmark_percent from display #76

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

ziesski
Copy link
Member

@ziesski ziesski commented Jul 1, 2024

Matching behavior of Submitty Repo

@zacharymnp zacharymnp changed the title rm benchmark_percent [Refactor:RainbowGrades] Remove benchmark_percent from display Jul 1, 2024
@micpap25
Copy link

micpap25 commented Jul 3, 2024

I don't think this is sufficient, for example look at line 568 of main.cpp. I think we could remove more references to it.

@ziesski
Copy link
Member Author

ziesski commented Jul 3, 2024

I don't think this is sufficient, for example look at line 568 of main.cpp. I think we could remove more references to it.

No, "benchmark_percent" that you are referring to is an independent token that should not get removed, which in fact is used to display benchmark percent (yes bad naming choice), we are trying to address benchmark_percent tag living inside of display token.

@micpap25
Copy link

micpap25 commented Jul 8, 2024

I don't think this is sufficient, for example look at line 568 of main.cpp. I think we could remove more references to it.

No, "benchmark_percent" that you are referring to is an independent token that should not get removed, which in fact is used to display benchmark percent (yes bad naming choice), we are trying to address benchmark_percent tag living inside of display token.

Would it be possible to change the name? If not I understand

@zacharymnp
Copy link

Removing the benchmark_percent tag inside of display should make changing the name of the other benchmark_percent redundant, since there will only be one token named benchmark_percent.

@bmcutler bmcutler merged commit f49ba8d into main Jul 9, 2024
1 of 2 checks passed
@bmcutler bmcutler deleted the rm_benchmark branch July 9, 2024 18:05
bmcutler pushed a commit to Submitty/Submitty that referenced this pull request Jul 9, 2024
### Please check if the PR fulfills these requirements:

* [ ] Tests for the changes have been added/updated (if possible)
* [ ] Documentation has been updated/added if relevant
* [ ] Screenshots are attached to Github PR if visual/UI changes were
made

Login to Instructor, then navigate to Grade Reports > Web-Based Rainbow
Grades Customization.

### What is the current behavior?
<!-- List issue if it fixes/closes/implements one using the "Fixes
#<number>" or "Closes #<number>" syntax -->
There is an unused checkbox for benchmark_percent under Display.
Benchmark percents are toggled using Display Benchmarks.

### What is the new behavior?
Removed benchmark_percent checkbox.

### Additional Information
Merge Submitty/RainbowGrades#76 simultaneously
so that behavior of Submitty and RainbowGrades repositories match.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants