Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:RainbowGrades] Make local_pull, local_push command #75

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

ziesski
Copy link
Member

@ziesski ziesski commented Jun 14, 2024

Closes #Submitty/Submitty/issues/10457

스크린샷 2024-06-14 오후 3 54 49

Currently make pull & push faces some rsync error as shown on screenshot above.
For reference, it used to run with root, we just had to set password for submitty_daemon.

From dev env, it is basically copying the directories, so new commands cp_pull & cp_push are introduced.

@ziesski ziesski requested a review from bmcutler June 14, 2024 20:08
@bmcutler
Copy link
Member

Looks good. Just do a bit of stress testing and make sure the copy works repeatedly (that it doesn't make nested copies of the files). Also, consider switching to rsync (will be a little faster if the files already exist or only need minor updates).

@ziesski
Copy link
Member Author

ziesski commented Jun 15, 2024

Looks good. Just do a bit of stress testing and make sure the copy works repeatedly (that it doesn't make nested copies of the files). Also, consider switching to rsync (will be a little faster if the files already exist or only need minor updates).

Renamed the cp_push and cp_pull to local_push & local_pull as we are no longer using cp command. Updated the title accordingly for future reference purposes.

switched to rsync, and used -azPq flag, azP is same as the original make pull & push, but added q flag is for suppressing the output messages. Otherwise each json and html files names will be printed which is a lot. But @bmcutler if you disagree and think we should output all information, feel free to edit my commit (just remove q flag) and merge.
I am adding screenshot of both with and without the q flag.

스크린샷 2024-06-14 오후 11 53 47 스크린샷 2024-06-14 오후 11 53 28

@ziesski ziesski changed the title [Feature:RainbowGrades] Make cp_pull and cp_push command [Feature:RainbowGrades] Make local_pull, local_push command Jun 15, 2024
@bmcutler bmcutler merged commit d2a0118 into main Jun 17, 2024
2 checks passed
@bmcutler bmcutler deleted the cppull_cppush branch June 17, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants