[Feature:RainbowGrades] Display RainbowGrades version #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#closes Submitty/Submitty/issues/9492 |
ziesski
commented
Aug 9, 2023
There was a problem hiding this comment.
It may be causing error when ran on web-base-customization page
fatal: detected dubious ownership in repository at '/usr/local/submitty/GIT_CHECKOUT/RainbowGrades'
To add an exception for this directory, call:
git config --global --add safe.directory /usr/local/submitty/GIT_CHECKOUT/RainbowGrades
Will fix it
ziesski
commented
Aug 10, 2023
musaabimran
requested review from
musaabimran
and removed request for
musaabimran
|
Resolved merge conflict |
bmcutler
added a commit
to Submitty/Submitty
that referenced
this pull request
Feb 24, 2024
Related to Submitty/RainbowGrades#56 ### What is the current behavior?  Currently, Git has security feature called safe directory. Checking version on web-based customization page is ran by submitty_daemon, which has permission problem. (Running it locally, the user is most likely a root user, won't encounter this issue) ### What is the new behavior?  During install_system process, the script will now create .gitconfig file in /home/submitty_daemon with owner/group being submitty_daemon. In .gitconfig file contains the safe directory: usr/local/submitty/GIT_CHECKOUT/RainbowGrades ### Other information? /etc/gitconfig file has hierarchy over this - causing permission error, so be careful when running git config --global --edit command or --system. Although local config can override system/global config, in our case it is checking etc/gitconfig file first and gives error (fatal: unable to access '/etc/gitconfig': permission denied) --------- Co-authored-by: Barb Cutler <[email protected]>
Xiayucheng1212
pushed a commit
to Xiayucheng1212/Submitty
that referenced
this pull request
Apr 3, 2024
Related to Submitty/RainbowGrades#56 ### What is the current behavior?  Currently, Git has security feature called safe directory. Checking version on web-based customization page is ran by submitty_daemon, which has permission problem. (Running it locally, the user is most likely a root user, won't encounter this issue) ### What is the new behavior?  During install_system process, the script will now create .gitconfig file in /home/submitty_daemon with owner/group being submitty_daemon. In .gitconfig file contains the safe directory: usr/local/submitty/GIT_CHECKOUT/RainbowGrades ### Other information? /etc/gitconfig file has hierarchy over this - causing permission error, so be careful when running git config --global --edit command or --system. Although local config can override system/global config, in our case it is checking etc/gitconfig file first and gives error (fatal: unable to access '/etc/gitconfig': permission denied) --------- Co-authored-by: Barb Cutler <[email protected]>
bmcutler
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
I tested this on my mac. I had to change the path where the RG_version is written. The original code made assumptions about the directory on the instructor's machine.
Before we merge this, please re-test that it works on the server with the nightly build with the replaced path. AND please get someone to test that it works on a Windows installation (I'm not sure that the environment variables syntax is compatible on all platforms).
|
@ziesski |
oliiso
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows all users of RainbowGrades (i.e. instructors and students) to see the build version at the bottom of the RainbowGrades page. This version info is vital as it allows instructors to know which version they are currently using.
Having this version information readily available will enable instructors to provide accurate details when reporting any issues or errors they encounter. In turn, developers can use this version information to identify any potential discrepancies caused by outdated versions and assist instructors more efficiently in resolving their concerns.
[Instructor view]
[student view]
