[Bugfix:Plagiarism] Bump base Docker image to Ubuntu 22.04 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamjallen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Our Docker image is currently based on Ubuntu 20.04. This is problematic because the main Lichen binary is compiled on the host machine and copied into the Lichen container at runtime, which requires both operating systems to be compatible. Eventually, we should do all of the compilation at image build time instead...
What is the new behavior?
The base Docker image has been bumped to Ubuntu 22.04. Due to a handful of version incompatibilities and other miscellaneous Lichen bugs, I also bumped clang to version 14 (the C++ tokenizer was broken), bumped python to 3.9, and fixed a regression introduced in Submitty/Submitty#9630.
Further Python version increases will break the Java tokenizer. I will make a separate PR to migrate away from
javac-parser, which hasn't been updated in 5 years now, and seems to be a dead project.