Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:Autograding] Add Erlang image #53

Merged
merged 11 commits into from
Oct 11, 2024
Merged

Conversation

ION606
Copy link
Contributor

@ION606 ION606 commented Sep 20, 2024

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

What is the current behavior?

N/A

What is the new behavior?

Can now run Erlang files

Other information?

I tested it using the code below

-module(concurrency).
-export([start/0, process/0]).

start() ->
    Pid = spawn(concurrency, process, []),
    Pid ! {self(), "Hello"},
    receive
        {Pid, Msg} -> io:format("Received message: ~p~n", [Msg])
    end.

process() ->
    receive
        {Sender, Msg} ->
            Sender ! {self(), Msg}
    end.

image

@cjreed121
Copy link
Member

CI took over an hour to build. Is there a reason you chose to build from source rather than install from apt?

@ION606
Copy link
Contributor Author

ION606 commented Sep 25, 2024

CI took over an hour to build. Is there a reason you chose to build from source rather than install from apt?

According to this and also my own testing (see image below) it does not appear that I can install the version of erlang we need using apt
image

I'm not sure why it's taking so long to build, it took me 240s to build completely. I'll try using erlang-solutions and see if it's faster

image

Copy link
Contributor

@DarthNyan DarthNyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@DarthNyan DarthNyan requested a review from cjreed121 October 4, 2024 21:12
@bmcutler bmcutler merged commit b22a0ef into Submitty:main Oct 11, 2024
3 checks passed
@ION606 ION606 deleted the erlang branch October 11, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants