feat: change to workspaceless

Signed-off-by: SuZhou-Joe <[email protected]>

src/core/public/application/application_service.tsx

@@ -263,14 +263,12 @@ export class ApplicationService {
 
       if (shouldNavigate) {
         const targetApp = applications$.value.get(appId);
-        if (
-          workspaces.currentWorkspaceId$.value &&
-          targetApp?.visibility === AppVisibility.homeOnly
-        ) {
-          // If user is inside a workspace and the target app is homeOnly
+        if (workspaces.currentWorkspaceId$.value && targetApp?.workspaceless) {
+          // If user is inside a workspace and the target app is workspaceless
           // refresh the page by doing a hard navigation
           window.location.assign(
             http.basePath.prepend(getAppUrl(availableMounters, appId, path), {
+              // Set withoutClientBasePath to true remove the workspace path prefix
               withoutClientBasePath: true,
             })
           );

src/core/public/application/types.ts

@@ -90,27 +90,6 @@ export enum AppNavLinkStatus {
   hidden = 3,
 }
 
-/**
- * Visibilities of the application
- *
- * @public
- */
-export enum AppVisibility {
-  /**
-   * The application visibility will be `both` if the application's {@link AppVisibility} is set to `default` or not set
-   * which means the application is visible within / out of workspace.
-   */
-  default = 0,
-  /**
-   * The application is only visible when user is inside a workspace.
-   */
-  workspaceOnly = 1,
-  /**
-   * The application is only visible when user is not in any workspace.
-   */
-  homeOnly = 2,
-}
-
 /**
  * Defines the list of fields that can be updated via an {@link AppUpdater}.
  * @public
@@ -268,11 +247,9 @@ export interface App<HistoryLocationState = unknown> {
   exactRoute?: boolean;
 
   /**
-   * The visibility of the application based on workspace.
-   * Defaulting to `both`
-   * See {@link AppVisibility}
+   * Prevent the page to be accessible when inside a workspace. Defaults to `false`.
    */
-  visibility?: AppVisibility;
+  workspaceless?: boolean;
 }
 
 /**

src/core/public/chrome/nav_links/to_nav_link.ts

@@ -36,7 +36,7 @@ import { appendAppPath } from '../../application/utils';
 export function toNavLink(app: PublicAppInfo, basePath: IBasePath): NavLinkWrapper {
   const useAppStatus = app.navLinkStatus === AppNavLinkStatus.default;
   let relativeBaseUrl = basePath.prepend(app.appRoute!);
-  if (app.visibility === AppVisibility.homeOnly) {
+  if (app.workspaceless) {
     relativeBaseUrl = basePath.prepend(app.appRoute!, { withoutClientBasePath: true });
   }
   const url = relativeToAbsolute(appendAppPath(relativeBaseUrl, app.defaultPath));

src/plugins/home/public/plugin.ts

@@ -130,7 +130,7 @@ export class HomePublicPlugin
         const { renderApp } = await import('./application');
         return await renderApp(params.element, coreStart, params.history);
       },
-      visibility: AppVisibility.homeOnly,
+      workspaceless: true,
     });
     urlForwarding.forwardApp('home', 'home');