Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for max seeding torrents per share limit group #399

Closed

Conversation

estebanthi
Copy link
Contributor

Description

Added a new max_seeding_torrents option in share_limits/[group] to only update share limits if there are more seeding torrents than max_seeding_torrents for the group.

With this comes a new option, max_seeding_torrents_options which prioritizes the torrents to which share limits are to be applied if there are more torrents than allowed.

Example: some hypothetical tracker allows seedbonus for max 100 torrents that are at least 50 MB in size.

  my-tracker:
    priority: 5
    include_any_tags:
    - my-tracker
    max_ratio: 5
    max_seeding_torrents: 100
    max_seeding_torrents_options:
      sort_by: last_activity
      sort_asc: false
      max_size: 50

Share limits will first apply to the least active torrents of less than 50 MB (if any), then to the least active torrents no matter the size, in order to keep just 100 seeding torrents.

Fixes #309 (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have modified this PR to merge to the develop branch

bobokun and others added 3 commits September 11, 2023 20:43
Bumps [gitpython](https://github.com/gitpython-developers/GitPython) from 3.1.35 to 3.1.36.
- [Release notes](https://github.com/gitpython-developers/GitPython/releases)
- [Changelog](https://github.com/gitpython-developers/GitPython/blob/main/CHANGES)
- [Commits](gitpython-developers/GitPython@3.1.35...3.1.36)

---
updated-dependencies:
- dependency-name: gitpython
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
…p/develop/gitpython-3.1.36

Bump gitpython from 3.1.35 to 3.1.36
@estebanthi estebanthi force-pushed the f-max_seeding_torrents branch 2 times, most recently from 9519036 to 34a1c6e Compare September 16, 2023 10:16
Improved cleanup torrents


Added get_dict


Added a subsubparent option


Moved torrents filtering before update share limits


Added missing config.log_level


gitignore
@estebanthi estebanthi force-pushed the f-max_seeding_torrents branch from ec5bd74 to 77abc89 Compare September 16, 2023 10:17
@bakerboy448
Copy link
Collaborator

conflicted

@bakerboy448 bakerboy448 added the conflict PR is conflicted and needs resolution label Apr 27, 2024
dependabot bot and others added 15 commits July 9, 2024 00:41
Bumps [humanize](https://github.com/python-humanize/humanize) from 4.9.0 to 4.10.0.
- [Release notes](https://github.com/python-humanize/humanize/releases)
- [Commits](python-humanize/humanize@4.9.0...4.10.0)

---
updated-dependencies:
- dependency-name: humanize
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [croniter](https://github.com/kiorky/croniter) from 2.0.5 to 2.0.7.
- [Changelog](https://github.com/kiorky/croniter/blob/master/CHANGELOG.rst)
- [Commits](corpusops/croniter@2.0.5...2.0.7)

---
updated-dependencies:
- dependency-name: croniter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [qbittorrent-api](https://github.com/rmartin16/qbittorrent-api) from 2024.5.63 to 2024.7.64.
- [Release notes](https://github.com/rmartin16/qbittorrent-api/releases)
- [Changelog](https://github.com/rmartin16/qbittorrent-api/blob/main/CHANGELOG.md)
- [Commits](rmartin16/qbittorrent-api@v2024.5.63...v2024.7.64)

---
updated-dependencies:
- dependency-name: qbittorrent-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [croniter](https://github.com/kiorky/croniter) from 3.0.1 to 3.0.3.
- [Changelog](https://github.com/kiorky/croniter/blob/master/CHANGELOG.rst)
- [Commits](corpusops/croniter@3.0.1...3.0.3)

---
updated-dependencies:
- dependency-name: croniter
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 3.7.1 to 3.8.0.
- [Release notes](https://github.com/pre-commit/pre-commit/releases)
- [Changelog](https://github.com/pre-commit/pre-commit/blob/main/CHANGELOG.md)
- [Commits](pre-commit/pre-commit@v3.7.1...v3.8.0)

---
updated-dependencies:
- dependency-name: pre-commit
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [flake8](https://github.com/pycqa/flake8) from 7.1.0 to 7.1.1.
- [Commits](PyCQA/flake8@7.1.0...7.1.1)

---
updated-dependencies:
- dependency-name: flake8
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@bakerboy448 bakerboy448 requested a review from bobokun August 20, 2024 16:43
@bakerboy448
Copy link
Collaborator

Abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict PR is conflicted and needs resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants