Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MFR and LCSC part numbers to schematic #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add MFR and LCSC part numbers to schematic #38

wants to merge 3 commits into from

Conversation

andistorm
Copy link
Collaborator

@andistorm andistorm commented Nov 6, 2024 •
edited
Loading

To allow creating JLCPCB-ready BOM from kicad, I added part numbers to schematic symbols

See also

@andistorm andistorm added documentation Improvements or additions to documentation enhancement New feature or request fabrication Improvements or additions to fabrication labels Nov 6, 2024
@andistorm andistorm force-pushed the feature/add-part-numbers-to-schematic branch from fe94f02 to 011a9f2 Compare November 6, 2024 23:22
@andistorm
Add part numbers to schematic
06f27ef 
* Add property `MFR Part #`
* Add property `LCSC`

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm andistorm force-pushed the feature/add-part-numbers-to-schematic branch from 011a9f2 to 06f27ef Compare November 7, 2024 19:28
@fschrempf
Copy link
Contributor

If possible could you please also set a property MPN as used by Aisler? I just tried and you can use a variable like MPN = ${MFR Part #} so the actual property values are not duplicated.

@andistorm
Copy link
Collaborator Author

If possible could you please also set a property MPN as used by Aisler? I just tried and you can use a variable like MPN = ${MFR Part #} so the actual property values are not duplicated.

I can rename it. The name wasn't required, I just added for completness

@fschrempf
Copy link
Contributor

fschrempf commented Nov 7, 2024 •
edited
Loading

I can rename it. The name wasn't required, I just added for completness

If the name doesn't matter and you could use MPN instead that would be great, as it would make the Aisler matching algorithm work out of the box.

@andistorm
Rename field to MPN
4aca16c 
Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm
Update PCB
ef654d6 
Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm andistorm changed the title Add MFR and LSCS part numbers to schematic Add MFR and LCSC part numbers to schematic Nov 7, 2024
@fschrempf
Copy link
Contributor

Awesome, thanks! One thing I noticed is that components S2 and S3 seem to have a value assigned that doesn't match the MPN/LCSC field. Everything else looks good to me.

@andistorm
Copy link
Collaborator Author

I noticed is that components S2 and S3 seem to have a value assigned that doesn't match the MPN/LCSC field

What do you mean by this? I looked again into it, but didn't notice anything conspicuous

@fschrempf
Copy link
Contributor

What do you mean by this? I looked again into it, but didn't notice anything conspicuous

S2 and S3 have TL4100AF240QG_ in the "Value" field and PTS810SJM250SMTRLFS in the "MPN" field, which seem to be two different types of switches.

@andistorm
Copy link
Collaborator Author

Ah, now I got it. This is because I orientated on the existing bom file. So I guess it would make sense to update S2 and S3 then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request fabrication Improvements or additions to fabrication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andistorm @fschrempf