Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add include dirs on linux #21

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add include dirs on linux #21

wants to merge 2 commits into from

Conversation

KevinBarbier2
Copy link

Fixes source header files not found on linux

In file included from ../src/beamcoder.cc:23:
../src/beamcoder_util.h:33:12: fatal error: libavutil/error.h: No such file or directory

@tommyZZM tommyZZM mentioned this pull request Mar 20, 2020
Open
@tommyZZM
Copy link

tommyZZM commented Mar 20, 2020 •
edited
Loading

this pull request should add a specific condition os=="linux" for linux only.

since macOS needs quite different include_dirs and library_dirs .

ref: #39 Add include_dirs and library_dirs for 'OS=="mac" to the binding.gyp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBarbier2 @tommyZZM